* Build error in timer-atmel-pit.c
@ 2016-08-29 4:42 Brent Taylor
2016-08-29 6:44 ` [PATCH] clocksource/drivers/atmel-pit: Fix compilation error Daniel Lezcano
0 siblings, 1 reply; 4+ messages in thread
From: Brent Taylor @ 2016-08-29 4:42 UTC (permalink / raw)
To: Daniel Lezcano; +Cc: Thomas Gleixner, linux-kernel
Daniel,
After updating to linux-4.8-rc4, I got the following build error:
linux-x.yy/drivers/clocksource/timer-atmel-pit.c: In function
'at91sam926x_pit_dt_init':
linux-x.yy/drivers/clocksource/timer-atmel-pit.c:264:2: error: 'ret'
undeclared (first use in this function)
ret = clk_prepare_enable(data->mck);
^~~
linux-x.yy/drivers/clocksource/timer-atmel-pit.c:264:2: note: each
undeclared identifier is reported only once for each function it
appears in
This was introduced in commit: 699e36e5b8e9f77b2be4c23f0b309e53be4b2880
Regards,
Brent Taylor
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] clocksource/drivers/atmel-pit: Fix compilation error
2016-08-29 4:42 Build error in timer-atmel-pit.c Brent Taylor
@ 2016-08-29 6:44 ` Daniel Lezcano
2016-08-29 6:50 ` Daniel Lezcano
2016-08-29 7:58 ` [tip:timers/urgent] " tip-bot for Daniel Lezcano
0 siblings, 2 replies; 4+ messages in thread
From: Daniel Lezcano @ 2016-08-29 6:44 UTC (permalink / raw)
To: tglx; +Cc: alexandre.belloni, realbright, motobud, linux-kernel, daniel.lezcano
The previous fix introduced a check against the ret variable which
is not defined, hence producing a compilation error:
linux/drivers/clocksource/timer-atmel-pit.c: In function ‘at91sam926x_pit_dt_init’:
linux/drivers/clocksource/timer-atmel-pit.c:264:2: error: ‘ret’ undeclared (first use in this function)
ret = clk_prepare_enable(data->mck);
^
linux/drivers/clocksource/timer-atmel-pit.c:264:2: note: each undeclared identifier is reported only once for each function it appears in
Add the missing the variable 'ret'.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/clocksource/timer-atmel-pit.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
index 3494bc5..7f0f5b2 100644
--- a/drivers/clocksource/timer-atmel-pit.c
+++ b/drivers/clocksource/timer-atmel-pit.c
@@ -240,6 +240,7 @@ static int __init at91sam926x_pit_common_init(struct pit_data *data)
static int __init at91sam926x_pit_dt_init(struct device_node *node)
{
struct pit_data *data;
+ int ret;
data = kzalloc(sizeof(*data), GFP_KERNEL);
if (!data)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] clocksource/drivers/atmel-pit: Fix compilation error
2016-08-29 6:44 ` [PATCH] clocksource/drivers/atmel-pit: Fix compilation error Daniel Lezcano
@ 2016-08-29 6:50 ` Daniel Lezcano
2016-08-29 7:58 ` [tip:timers/urgent] " tip-bot for Daniel Lezcano
1 sibling, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2016-08-29 6:50 UTC (permalink / raw)
To: tglx; +Cc: alexandre.belloni, realbright, motobud, linux-kernel
On 08/29/2016 08:44 AM, Daniel Lezcano wrote:
> The previous fix introduced a check against the ret variable which
> is not defined, hence producing a compilation error:
>
> linux/drivers/clocksource/timer-atmel-pit.c: In function ‘at91sam926x_pit_dt_init’:
> linux/drivers/clocksource/timer-atmel-pit.c:264:2: error: ‘ret’ undeclared (first use in this function)
> ret = clk_prepare_enable(data->mck);
> ^
> linux/drivers/clocksource/timer-atmel-pit.c:264:2: note: each undeclared identifier is reported only once for each function it appears in
>
> Add the missing the variable 'ret'.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
Thomas,
do you mind to directly apply this patch ?
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:timers/urgent] clocksource/drivers/atmel-pit: Fix compilation error
2016-08-29 6:44 ` [PATCH] clocksource/drivers/atmel-pit: Fix compilation error Daniel Lezcano
2016-08-29 6:50 ` Daniel Lezcano
@ 2016-08-29 7:58 ` tip-bot for Daniel Lezcano
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Daniel Lezcano @ 2016-08-29 7:58 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, tglx, daniel.lezcano, mingo
Commit-ID: 98744b408c757901df57fa50cbd5826245dc3a1f
Gitweb: http://git.kernel.org/tip/98744b408c757901df57fa50cbd5826245dc3a1f
Author: Daniel Lezcano <daniel.lezcano@linaro.org>
AuthorDate: Mon, 29 Aug 2016 08:44:03 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 29 Aug 2016 09:51:39 +0200
clocksource/drivers/atmel-pit: Fix compilation error
The previous fix introduced a check against the ret variable which
is not defined, hence producing a compilation error:
linux/drivers/clocksource/timer-atmel-pit.c: In function ‘at91sam926x_pit_dt_init’:
linux/drivers/clocksource/timer-atmel-pit.c:264:2: error: ‘ret’ undeclared (first use in this function)
ret = clk_prepare_enable(data->mck);
^
linux/drivers/clocksource/timer-atmel-pit.c:264:2: note: each undeclared identifier is reported only once for each function it appears in
Add the missing the variable 'ret'.
Fixes: 504f34c9e45c "clocksource/drivers/atmel-pit: Convert init function to return error"
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: alexandre.belloni@free-electrons.com
Cc: motobud@gmail.com
Cc: realbright@lgcns.com
Link: http://lkml.kernel.org/r/1472453043-24287-1-git-send-email-daniel.lezcano@linaro.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/clocksource/timer-atmel-pit.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
index 3494bc5..7f0f5b2 100644
--- a/drivers/clocksource/timer-atmel-pit.c
+++ b/drivers/clocksource/timer-atmel-pit.c
@@ -240,6 +240,7 @@ static int __init at91sam926x_pit_common_init(struct pit_data *data)
static int __init at91sam926x_pit_dt_init(struct device_node *node)
{
struct pit_data *data;
+ int ret;
data = kzalloc(sizeof(*data), GFP_KERNEL);
if (!data)
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-29 7:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-29 4:42 Build error in timer-atmel-pit.c Brent Taylor
2016-08-29 6:44 ` [PATCH] clocksource/drivers/atmel-pit: Fix compilation error Daniel Lezcano
2016-08-29 6:50 ` Daniel Lezcano
2016-08-29 7:58 ` [tip:timers/urgent] " tip-bot for Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).