* [PATCH v2] drm/nouveau/gr: mark gm107_grctx_generate_tpcid() static
@ 2016-08-29 13:02 Baoyou Xie
2016-08-29 16:01 ` Sean Paul
0 siblings, 1 reply; 3+ messages in thread
From: Baoyou Xie @ 2016-08-29 13:02 UTC (permalink / raw)
To: bskeggs, airlied
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 1 warning when build kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
so this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
index 6d3c501..4c4b5ab 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
@@ -933,7 +933,7 @@ gm107_grctx_generate_attrib(struct gf100_grctx *info)
}
}
-void
+static void
gm107_grctx_generate_tpcid(struct gf100_gr *gr)
{
struct nvkm_device *device = gr->base.engine.subdev.device;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/nouveau/gr: mark gm107_grctx_generate_tpcid() static
2016-08-29 13:02 [PATCH v2] drm/nouveau/gr: mark gm107_grctx_generate_tpcid() static Baoyou Xie
@ 2016-08-29 16:01 ` Sean Paul
[not found] ` <CA+DQWkws5sJMnJagECjXdbEKOdFZ8LLbwm9ng6dYt26KUXUQRQ@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Sean Paul @ 2016-08-29 16:01 UTC (permalink / raw)
To: Baoyou Xie
Cc: bskeggs, Dave Airlie, dri-devel, nouveau,
Linux Kernel Mailing List, Arnd Bergmann, xie.baoyou
On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie <baoyou.xie@linaro.org> wrote:
> We get 1 warning when build kernel with W=1:
> drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> so this patch marks this function with 'static'.
>
It would make things a lot easier if you either consolidated all of
these static changes into one patch, or released them as a series.
Sean
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
> index 6d3c501..4c4b5ab 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
> @@ -933,7 +933,7 @@ gm107_grctx_generate_attrib(struct gf100_grctx *info)
> }
> }
>
> -void
> +static void
> gm107_grctx_generate_tpcid(struct gf100_gr *gr)
> {
> struct nvkm_device *device = gr->base.engine.subdev.device;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/nouveau/gr: mark gm107_grctx_generate_tpcid() static
[not found] ` <CA+DQWkws5sJMnJagECjXdbEKOdFZ8LLbwm9ng6dYt26KUXUQRQ@mail.gmail.com>
@ 2016-08-30 12:40 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-08-30 12:40 UTC (permalink / raw)
To: Baoyou Xie
Cc: Sean Paul, bskeggs, Dave Airlie, dri-devel, nouveau,
Linux Kernel Mailing List, xie.baoyou
On Tuesday 30 August 2016, Baoyou Xie wrote:
> On 30 August 2016 at 00:01, Sean Paul <seanpaul@google.com> wrote:
>
> > On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie <baoyou.xie@linaro.org> wrote:
> > > We get 1 warning when build kernel with W=1:
> > > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no
> > previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes]
> > >
> > > In fact, this function is only used in the file in which it is
> > > declared and don't need a declaration, but can be made static.
> > > so this patch marks this function with 'static'.
> > >
> >
> > It would make things a lot easier if you either consolidated all of
> > these static changes into one patch, or released them as a series.
> >
> >
> Do you mean that I need to consolidate all of them into one patch this
> time? or next time?
I'd suggest consolidating the 'nouveau' changes into a single patch,
as this is one (very big) driver and resend that one.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-30 12:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-29 13:02 [PATCH v2] drm/nouveau/gr: mark gm107_grctx_generate_tpcid() static Baoyou Xie
2016-08-29 16:01 ` Sean Paul
[not found] ` <CA+DQWkws5sJMnJagECjXdbEKOdFZ8LLbwm9ng6dYt26KUXUQRQ@mail.gmail.com>
2016-08-30 12:40 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).