From: Paul Kocialkowski <contact@paulk.fr>
To: Sebastian Reichel <sre@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/2] power: bq24735-charger: Request status GPIO with initial input setup
Date: Mon, 29 Aug 2016 20:13:22 +0200 [thread overview]
Message-ID: <1472494402.9437.0.camel@paulk.fr> (raw)
In-Reply-To: <20160829003652.hs4tk7qmvu25mqhb@earth>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
Le lundi 29 août 2016 à 02:36 +0200, Sebastian Reichel a écrit :
> Hi,
>
> On Sun, Aug 28, 2016 at 07:34:45PM +0200, Paul Kocialkowski wrote:
> >
> > This requests the status GPIO with initial input setup. it is required
> > to read the GPIO status at probe time and thus correctly avoid sending
> > i2c messages when AC is not plugged.
> >
> > When requesting the GPIO without initial input setup, it always reads 0
> > which causes probe to fail as it assumes the charger is connected, sends
> > i2c messages and fails.
>
> Please convert the driver to devm_gpiod_get instead.
Sure thing, see v2.
Thanks!
--
Paul Kocialkowski, developer of low-level free software for embedded devices
Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2016-08-29 18:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-28 17:34 [PATCH 1/2] power: bq24735-charger: Request status GPIO with initial input setup Paul Kocialkowski
2016-08-28 17:34 ` [PATCH 2/2] power: bq24735-charger: Assume not charging when charger is missing Paul Kocialkowski
2016-08-29 0:40 ` Sebastian Reichel
2016-08-29 0:36 ` [PATCH 1/2] power: bq24735-charger: Request status GPIO with initial input setup Sebastian Reichel
2016-08-29 18:13 ` Paul Kocialkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472494402.9437.0.camel@paulk.fr \
--to=contact@paulk.fr \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).