From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755583AbcH2TeR (ORCPT ); Mon, 29 Aug 2016 15:34:17 -0400 Received: from smtprelay0239.hostedemail.com ([216.40.44.239]:41040 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753932AbcH2TeQ (ORCPT ); Mon, 29 Aug 2016 15:34:16 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2828:2859:2892:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:8985:9025:10004:10400:10848:11026:11232:11473:11658:11783:11914:12043:12438:12555:12740:13069:13311:13357:13439:13894:14181:14659:14721:21080:21434:30012:30054:30064:30075:30083:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: pail15_24e10f732e63b X-Filterd-Recvd-Size: 1909 Message-ID: <1472499252.3425.93.camel@perches.com> Subject: Re: [Ksummit-discuss] checkkpatch (in)sanity ? From: Joe Perches To: Dan Carpenter , Josh Triplett Cc: ksummit-discuss@lists.linuxfoundation.org, Greg KH , Sasha Levin , LKML Date: Mon, 29 Aug 2016 12:34:12 -0700 In-Reply-To: <20160829191701.GL4129@mwanda> References: <1472330452.26978.23.camel@perches.com> <20160829190618.GF4180@mwanda> <20160829191020.GB27600@cloud> <20160829191701.GL4129@mwanda> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-08-29 at 22:17 +0300, Dan Carpenter wrote: > On Mon, Aug 29, 2016 at 12:10:20PM -0700, Josh Triplett wrote: > > On Mon, Aug 29, 2016 at 10:06:18PM +0300, Dan Carpenter wrote: > > > I would like a couple changes which you know already: > > > > > > 1) Get rid of PREFER_ETHER_ADDR_COPY and similar because the people who > > > send checkpatch.pl fixes aren't qualified to say when it's legal or not > > > so they sometimes introduce bugs. > > I do think we should have *something* that catches such things. > > Perhaps not checkpatch.pl, though.  Perhaps a compiler plugin that > > generates additional warnings, and can perhaps use more global > > information to determine legality? > Perhaps.  But that shouldn't delay us from deleting this code which just > encourages newbies to introduce bugs. You could send a patch. I still kinda like the --force option https://patchwork.kernel.org/patch/5814071/