From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "dan.j.williams@intel.com" <dan.j.williams@intel.com>
Cc: "kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
"mike.kravetz@oracle.com" <mike.kravetz@oracle.com>,
"mawilcox@microsoft.com" <mawilcox@microsoft.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
"tytso@mit.edu" <tytso@mit.edu>,
"david@fromorbit.com" <david@fromorbit.com>,
"jack@suse.cz" <jack@suse.cz>
Subject: Re: [PATCH v4 RESEND 1/2] thp, dax: add thp_get_unmapped_area for pmd mappings
Date: Mon, 29 Aug 2016 20:44:57 +0000 [thread overview]
Message-ID: <1472503455.1532.28.camel@hpe.com> (raw)
In-Reply-To: <CAPcyv4hJ1DrCkBCwqm02e1D85wtSPwUaSG2S84JaDJwFWA_4hA@mail.gmail.com>
On Mon, 2016-08-29 at 12:34 -0700, Dan Williams wrote:
> On Mon, Aug 29, 2016 at 12:11 PM, Toshi Kani <toshi.kani@hpe.com>
> wrote:
> >
> > When CONFIG_FS_DAX_PMD is set, DAX supports mmap() using pmd page
> > size. This feature relies on both mmap virtual address and FS
> > block (i.e. physical address) to be aligned by the pmd page size.
> > Users can use mkfs options to specify FS to align block
> > allocations. However, aligning mmap address requires code changes
> > to existing applications for providing a pmd-aligned address to
> > mmap().
> >
> > For instance, fio with "ioengine=mmap" performs I/Os with mmap()
> > [1]. It calls mmap() with a NULL address, which needs to be changed
> > to provide a pmd-aligned address for testing with DAX pmd mappings.
> > Changing all applications that call mmap() with NULL is
> > undesirable.
> >
> > Add thp_get_unmapped_area(), which can be called by filesystem's
> > get_unmapped_area to align an mmap address by the pmd size for
> > a DAX file. It calls the default handler, mm->get_unmapped_area(),
> > to find a range and then aligns it for a DAX file.
> >
> > The patch is based on Matthew Wilcox's change that allows adding
> > support of the pud page size easily.
:
>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Great!
> ...with one minor nit:
>
>
> >
> > include/linux/huge_mm.h | 7 +++++++
> > mm/huge_memory.c | 43
> > +++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 50 insertions(+)
> >
> > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
> > index 6f14de4..4fca526 100644
> > --- a/include/linux/huge_mm.h
> > +++ b/include/linux/huge_mm.h
> > @@ -87,6 +87,10 @@ extern bool is_vma_temporary_stack(struct
> > vm_area_struct *vma);
> >
> > extern unsigned long transparent_hugepage_flags;
> >
> > +extern unsigned long thp_get_unmapped_area(struct file *filp,
> > + unsigned long addr, unsigned long len, unsigned
> > long pgoff,
> > + unsigned long flags);
> > +
> > extern void prep_transhuge_page(struct page *page);
> > extern void free_transhuge_page(struct page *page);
> >
> > @@ -169,6 +173,9 @@ void put_huge_zero_page(void);
> > static inline void prep_transhuge_page(struct page *page) {}
> >
> > #define transparent_hugepage_flags 0UL
> > +
> > +#define thp_get_unmapped_area NULL
>
> Lets make this:
>
> static inline unsigned long thp_get_unmapped_area(struct file *filp,
> unsigned long addr, unsigned long len, unsigned long
> pgoff,
> unsigned long flags)
> {
> return 0;
> }
>
> ...to get some type checking in the CONFIG_TRANSPARENT_HUGEPAGE=n
> case.
>
Per get_unmapped_area() in mm/mmap.c, I think we need to set it to NULL
when we do not override current->mm->get_unmapped_area.
Thanks!
-Toshi
next prev parent reply other threads:[~2016-08-29 20:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 19:11 [PATCH v4 RESEND 0/2] Align mmap address for DAX pmd mappings Toshi Kani
2016-08-29 19:11 ` [PATCH v4 RESEND 1/2] thp, dax: add thp_get_unmapped_area for " Toshi Kani
2016-08-29 19:34 ` Dan Williams
2016-08-29 20:44 ` Kani, Toshimitsu [this message]
2016-08-29 20:54 ` Dan Williams
2016-08-29 19:11 ` [PATCH v4 RESEND 2/2] ext2/4, xfs: call thp_get_unmapped_area() " Toshi Kani
2016-08-29 20:48 ` [PATCH v4 RESEND 0/2] Align mmap address for DAX " Kirill A. Shutemov
2016-08-29 21:32 ` Kani, Toshimitsu
2016-08-29 22:00 ` Kani, Toshimitsu
2016-09-08 10:57 ` Kirill A. Shutemov
2016-09-08 13:49 ` Kani, Toshimitsu
2016-09-08 23:21 ` Kani, Toshimitsu
2016-09-09 12:36 ` Kirill A. Shutemov
2016-09-09 17:21 ` Kani, Toshimitsu
2016-09-09 18:37 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472503455.1532.28.camel@hpe.com \
--to=toshi.kani@hpe.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=mawilcox@microsoft.com \
--cc=mike.kravetz@oracle.com \
--cc=ross.zwisler@linux.intel.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).