From: Mike Galbraith <mgalbraith@suse.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Rik van Riel <riel@redhat.com>
Subject: [patch v3.18+ regression fix] sched: Further improve spurious CPU_IDLE active migrations
Date: Tue, 30 Aug 2016 07:42:55 +0200 [thread overview]
Message-ID: <1472535775.3960.3.camel@suse.de> (raw)
43f4d666 partially cured spurious migrations, but when there are
completely idle groups on a lightly loaded processor, and there is
a buddy pair occupying the busiest group, we will not attempt to
migrate due to select_idle_sibling() buddy placement, leaving the
busiest queue with one task. We skip balancing, but increment
nr_balance_failed until we kick active balancing, and bounce a
buddy pair endlessly, demolishing throughput.
Regression detected on X5472 box, which has 4 MC groups of 2 cores.
netperf -l 60 -H 127.0.0.1 -t UDP_STREAM -i5,1 -I 95,5
pre:
!!! WARNING
!!! Desired confidence was not achieved within the specified iterations.
!!! This implies that there was variability in the test environment that
!!! must be investigated before going further.
!!! Confidence intervals: Throughput : 66.421%
!!! Local CPU util : 0.000%
!!! Remote CPU util : 0.000%
Socket Message Elapsed Messages
Size Size Time Okay Errors Throughput
bytes bytes secs # # 10^6bits/sec
212992 65507 60.00 1779143 0 15539.49
212992 60.00 1773551 15490.65
post:
Socket Message Elapsed Messages
Size Size Time Okay Errors Throughput
bytes bytes secs # # 10^6bits/sec
212992 65507 60.00 3719377 0 32486.01
212992 60.00 3717492 32469.54
Signed-off-by: Mike Galbraith <mgalbraith@suse.de>
Fixes: caeb178c sched/fair: Make update_sd_pick_busiest() return 'true' on a busier sd
Cc: <stable@vger.kernel.org> # v3.18+
---
kernel/sched/fair.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -7249,11 +7249,12 @@ static struct sched_group *find_busiest_
* This cpu is idle. If the busiest group is not overloaded
* and there is no imbalance between this and busiest group
* wrt idle cpus, it is balanced. The imbalance becomes
- * significant if the diff is greater than 1 otherwise we
- * might end up to just move the imbalance on another group
+ * significant if the diff is greater than 2 otherwise we
+ * may end up merely moving the imbalance to another group,
+ * or bouncing a buddy pair needlessly.
*/
if ((busiest->group_type != group_overloaded) &&
- (local->idle_cpus <= (busiest->idle_cpus + 1)))
+ (local->idle_cpus <= (busiest->idle_cpus + 2)))
goto out_balanced;
} else {
/*
next reply other threads:[~2016-08-30 5:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 5:42 Mike Galbraith [this message]
2016-08-31 10:01 ` [patch v3.18+ regression fix] sched: Further improve spurious CPU_IDLE active migrations Peter Zijlstra
2016-08-31 10:18 ` Mike Galbraith
2016-08-31 10:36 ` Mike Galbraith
2016-08-31 15:52 ` Vincent Guittot
2016-09-01 4:11 ` Mike Galbraith
2016-09-01 6:37 ` Mike Galbraith
2016-09-01 8:09 ` Vincent Guittot
2016-09-05 16:26 ` [v2 patch " Mike Galbraith
2016-09-06 13:01 ` Vincent Guittot
2016-09-06 13:07 ` Mike Galbraith
2016-09-06 13:42 ` Vincent Guittot
2016-09-06 13:59 ` Mike Galbraith
2016-09-06 13:44 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472535775.3960.3.camel@suse.de \
--to=mgalbraith@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).