From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758294AbcH3RSy (ORCPT ); Tue, 30 Aug 2016 13:18:54 -0400 Received: from broadband.actcorp.in ([103.227.96.182]:3462 "EHLO arvind-ThinkPad-Edge-E431" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1755434AbcH3RSx (ORCPT ); Tue, 30 Aug 2016 13:18:53 -0400 From: Arvind Yadav To: daniel.lezcano@linaro.org Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, Li.Xiubo@freescale.com, Arvind Yadav Subject: [PATCH] clocksource: Freescale: handle of_iomap failures in legacy timer driver Date: Tue, 30 Aug 2016 22:39:22 +0530 Message-Id: <1472576962-9826-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Check return value of of_iomap and handle errors correctly. Signed-off-by: Arvind Yadav --- drivers/clocksource/fsl_ftm_timer.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/clocksource/fsl_ftm_timer.c b/drivers/clocksource/fsl_ftm_timer.c index 738515b..c42d159 100644 --- a/drivers/clocksource/fsl_ftm_timer.c +++ b/drivers/clocksource/fsl_ftm_timer.c @@ -335,36 +335,40 @@ static int __init ftm_timer_init(struct device_node *np) priv->clksrc_base = of_iomap(np, 1); if (!priv->clksrc_base) { pr_err("ftm: unable to map source timer registers\n"); - goto err; + goto err1; } ret = -EINVAL; irq = irq_of_parse_and_map(np, 0); if (irq <= 0) { pr_err("ftm: unable to get IRQ from DT, %d\n", irq); - goto err; + goto err2; } priv->big_endian = of_property_read_bool(np, "big-endian"); freq = ftm_clk_init(np); if (!freq) - goto err; + goto err2; ret = ftm_calc_closest_round_cyc(freq); if (ret) - goto err; + goto err2; ret = ftm_clocksource_init(freq); if (ret) - goto err; + goto err2; ret = ftm_clockevent_init(freq, irq); if (ret) - goto err; + goto err2; return 0; +err2: + iounmap(priv->clksrc_base); +err1: + iounmap(priv->clkevt_base); err: kfree(priv); return ret; -- 2.7.4