From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933747AbcHaKig (ORCPT ); Wed, 31 Aug 2016 06:38:36 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33332 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933349AbcHaKg0 (ORCPT ); Wed, 31 Aug 2016 06:36:26 -0400 Message-ID: <1472639782.3942.27.camel@gmail.com> Subject: Re: [patch v3.18+ regression fix] sched: Further improve spurious CPU_IDLE active migrations From: Mike Galbraith To: Peter Zijlstra Cc: LKML , Rik van Riel , Vincent Guittot Date: Wed, 31 Aug 2016 12:36:22 +0200 In-Reply-To: <1472638699.3942.14.camel@suse.de> References: <1472535775.3960.3.camel@suse.de> <20160831100117.GV10121@twins.programming.kicks-ass.net> <1472638699.3942.14.camel@suse.de> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-08-31 at 12:18 +0200, Mike Galbraith wrote: > On Wed, 2016-08-31 at 12:01 +0200, Peter Zijlstra wrote: > > So 43f4d66637bc ("sched: Improve sysbench performance by fixing spurious > > active migration") 's +1 made sense in that its a tie breaker. If you > > have 3 tasks on 2 groups, one group will have to have 2 tasks, and > > bouncing the one task around just isn't going to help _anything_. > > Yeah, but frequently tasks don't come in ones, so, you end up with an > endless tug of war between LB ripping communicating buddies apart, and > select_idle_sibling() pulling them back together.. bouncing cow > syndrome. The whole business of trying to balance groups down to the single task seems a bit illogical given we care enough to wake to shared cache in the first place, creating the 'imbalance' we then try to correct. 'course that weakens your unrelated tasks (which may meet on a sleepin g lock or whatever) argument not one bit, it's also valid. hrm. -Mike