From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: Rob Herring <robh@kernel.org>
Cc: <lee.jones@linaro.org>, <patches@opensource.wolfsonmicro.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mfd: arizona: Add DT options for max_channels_clocked and PDM speaker config
Date: Fri, 2 Sep 2016 16:56:24 +0100 [thread overview]
Message-ID: <1472831784.4359.6.camel@rf-debian.wolfsonmicro.main> (raw)
In-Reply-To: <20160902153458.GA28352@rob-hp-laptop>
On Fri, 2016-09-02 at 10:34 -0500, Rob Herring wrote:
> On Wed, Aug 31, 2016 at 10:25:43AM +0100, Richard Fitzgerald wrote:
> > This patch adds DT settings for the max_channels_clocked, spk_fmt and
> > spk_mute pdata.
> >
> > Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> > ---
> > Documentation/devicetree/bindings/mfd/arizona.txt | 11 ++++++++
>
> Binding looks fine, but...
>
> > drivers/mfd/arizona-core.c | 31 +++++++++++++++++++++++
> > 2 files changed, 42 insertions(+)
>
> > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> > index b95ff2d..36a9633 100644
> > --- a/drivers/mfd/arizona-core.c
> > +++ b/drivers/mfd/arizona-core.c
> > @@ -816,6 +816,37 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
> > count++;
> > }
> >
> > + count = 0;
> > + of_property_for_each_u32(arizona->dev->of_node,
> > + "wlf,max-channels-clocked",
> > + prop, cur, val) {
> > + if (count == ARRAY_SIZE(pdata->max_channels_clocked))
> > + break;
> > +
> > + pdata->max_channels_clocked[count] = val;
> > + count++;
> > + }
>
> of_property_read_u32_array doesn't work for you?
No, it doesn't, because it doesn't read a variable-sized array.
>
> > +
> > + count = 0;
> > + of_property_for_each_u32(arizona->dev->of_node, "wlf,spk-fmt", prop,
> > + cur, val) {
> > + if (count == ARRAY_SIZE(pdata->spk_fmt))
> > + break;
> > +
> > + pdata->spk_fmt[count] = val;
> > + count++;
> > + }
> > +
> > + count = 0;
> > + of_property_for_each_u32(arizona->dev->of_node, "wlf,spk-mute", prop,
> > + cur, val) {
> > + if (count == ARRAY_SIZE(pdata->spk_mute))
> > + break;
> > +
> > + pdata->spk_mute[count] = val;
> > + count++;
> > + }
> > +
> > return 0;
> > }
> >
> > --
> > 1.9.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-09-02 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 9:25 [PATCH v2] mfd: arizona: Add DT options for max_channels_clocked and PDM speaker config Richard Fitzgerald
2016-08-31 12:15 ` Lee Jones
2016-09-02 15:34 ` Rob Herring
2016-09-02 15:56 ` Richard Fitzgerald [this message]
2016-09-02 17:51 ` Rob Herring
2016-09-05 9:22 ` Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472831784.4359.6.camel@rf-debian.wolfsonmicro.main \
--to=rf@opensource.wolfsonmicro.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).