From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Peter Huewe <peterhuewe@gmx.de>
Cc: linux-security-module@vger.kernel.org,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net (moderated list:TPM DEVICE
DRIVER), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 4/4] tpm_crb: fix incorrect values of cmdReady and goIdle bits
Date: Fri, 2 Sep 2016 22:34:20 +0300 [thread overview]
Message-ID: <1472844861-24599-5-git-send-email-jarkko.sakkinen@linux.intel.com> (raw)
In-Reply-To: <1472844861-24599-1-git-send-email-jarkko.sakkinen@linux.intel.com>
CRB_CTRL_CMD_READY and CRB_CTRL_GO_IDLE have incorrect values.
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
drivers/char/tpm/tpm_crb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c
index c8b0d91..7f602dc 100644
--- a/drivers/char/tpm/tpm_crb.c
+++ b/drivers/char/tpm/tpm_crb.c
@@ -35,8 +35,8 @@ enum crb_defaults {
};
enum crb_ctrl_req {
- CRB_CTRL_REQ_GO_IDLE = BIT(0),
- CRB_CTRL_REQ_CMD_READY = BIT(1),
+ CRB_CTRL_REQ_CMD_READY = BIT(0),
+ CRB_CTRL_REQ_GO_IDLE = BIT(1),
};
enum crb_ctrl_sts {
--
2.7.4
next prev parent reply other threads:[~2016-09-02 19:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 19:34 [PATCH 0/4] Small fixes and cleanups for tpm_crb Jarkko Sakkinen
2016-09-02 19:34 ` [PATCH 1/4] tpm_crb: fix crb_req_canceled behavior Jarkko Sakkinen
2016-09-02 19:34 ` [PATCH 2/4] tpm_crb: remove wmb()'s Jarkko Sakkinen
2016-09-02 19:34 ` [PATCH 3/4] tpm_crb: refine the naming of constants Jarkko Sakkinen
2016-09-02 19:34 ` Jarkko Sakkinen [this message]
2016-09-02 19:41 ` [PATCH 4/4] tpm_crb: fix incorrect values of cmdReady and goIdle bits Jarkko Sakkinen
2016-09-03 6:27 ` [PATCH 0/4] Small fixes and cleanups for tpm_crb Jarkko Sakkinen
2016-09-03 6:41 ` Jarkko Sakkinen
2016-09-08 10:27 ` Jarkko Sakkinen
2016-09-08 11:35 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472844861-24599-5-git-send-email-jarkko.sakkinen@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stefanb@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).