From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933708AbcIENST (ORCPT ); Mon, 5 Sep 2016 09:18:19 -0400 Received: from bran.ispras.ru ([83.149.199.196]:23390 "EHLO smtp.ispras.ru" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933652AbcIENSO (ORCPT ); Mon, 5 Sep 2016 09:18:14 -0400 From: Pavel Andrianov To: Samuel Thibault Cc: Pavel Andrianov , William Hubbs , Chris Brannon , Kirk Reiser , Greg Kroah-Hartman , Shraddha Barke , Dilek Uzulmez , speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, vaishali.thakkar@oracle.com, ldv-project@linuxtesting.org Subject: [PATCH] speakup: Add spinlock in synth_direct_store Date: Mon, 5 Sep 2016 16:17:47 +0300 Message-Id: <1473081467-1892-1-git-send-email-andrianov@ispras.ru> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All operations with synth buffer should be protected, as there are global pointers, which should be modified atomically. Found by Linux Driver Verification project (linuxtesting.org) Signed-off-by: Pavel Andrianov --- drivers/staging/speakup/kobjects.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c index 528cbdc..7fedee3 100644 --- a/drivers/staging/speakup/kobjects.c +++ b/drivers/staging/speakup/kobjects.c @@ -411,11 +411,13 @@ static ssize_t synth_direct_store(struct kobject *kobj, int len; int bytes; const char *ptr = buf; + unsigned long flags; if (!synth) return -EPERM; len = strlen(buf); + spin_lock_irqsave(&speakup_info.spinlock, flags); while (len > 0) { bytes = min_t(size_t, len, 250); strncpy(tmp, ptr, bytes); @@ -425,6 +427,7 @@ static ssize_t synth_direct_store(struct kobject *kobj, ptr += bytes; len -= bytes; } + spin_unlock_irqrestore(&speakup_info.spinlock, flags); return count; } -- 2.7.4