From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752808AbcIGFZf (ORCPT <rfc822;w@1wt.eu>);
        Wed, 7 Sep 2016 01:25:35 -0400
Received: from mailgw01.mediatek.com ([210.61.82.183]:50693 "EHLO
        mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
        with ESMTP id S1752381AbcIGFZe (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 7 Sep 2016 01:25:34 -0400
Message-ID: <1473225929.10038.0.camel@mtksdaap41>
Subject: Re: [PATCH] vcodec: mediatek: fix odd_ptr_err.cocci warnings
From: Tiffany Lin <tiffany.lin@mediatek.com>
To: Julia Lawall <julia.lawall@lip6.fr>
CC: Hans Verkuil <hverkuil@xs4all.nl>,
        Mauro Carvalho Chehab <m.chehab@samsung.com>,
        <linux-media@vger.kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <kbuild-all@01.org>
Date: Wed, 7 Sep 2016 13:25:29 +0800
In-Reply-To: <alpine.DEB.2.10.1609062249430.3144@hadrien>
References: <alpine.DEB.2.10.1609062249430.3144@hadrien>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2016-09-06 at 22:51 +0800, Julia Lawall wrote:
> PTR_ERR should access the value just tested by IS_ERR
> 
> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
> 
> CC: Tiffany Lin <tiffany.lin@mediatek.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Reviewed-by:Tiffany Lin <tiffany.lin@mediatek.com>

> ---
> 
>  mtk_vcodec_dec_drv.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c
> @@ -255,7 +255,7 @@ static int mtk_vcodec_probe(struct platf
>  		}
>  		dev->reg_base[i] = devm_ioremap_resource(&pdev->dev, res);
>  		if (IS_ERR((__force void *)dev->reg_base[i])) {
> -			ret = PTR_ERR((__force void *)dev->reg_base);
> +			ret = PTR_ERR((__force void *)dev->reg_base[i]);
>  			goto err_res;
>  		}
>  		mtk_v4l2_debug(2, "reg[%d] base=%p", i, dev->reg_base[i]);