From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938796AbcIGLgi (ORCPT ); Wed, 7 Sep 2016 07:36:38 -0400 Received: from mga06.intel.com ([134.134.136.31]:27544 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbcIGLgd (ORCPT ); Wed, 7 Sep 2016 07:36:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,296,1470726000"; d="scan'208";a="1046753883" Message-ID: <1473248188.11323.40.camel@linux.intel.com> Subject: Re: [PATCH v2 4/5] gpio: pca953x: remove an unused variable From: Andy Shevchenko To: Bartosz Golaszewski , Linus Walleij , Alexandre Courbot , Vignesh R , Yong Li , Geert Uytterhoeven Cc: linux-gpio , LKML Date: Wed, 07 Sep 2016 14:36:28 +0300 In-Reply-To: <1473240297-19881-5-git-send-email-bgolaszewski@baylibre.com> References: <1473240297-19881-1-git-send-email-bgolaszewski@baylibre.com> <1473240297-19881-5-git-send-email-bgolaszewski@baylibre.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-09-07 at 11:24 +0200, Bartosz Golaszewski wrote: > The chip_type variable in struct pca953x_chip is no longer required. > > Remove it. Would it be patch 4 in the series? > > Signed-off-by: Bartosz Golaszewski > --- >  drivers/gpio/gpio-pca953x.c | 5 +---- >  1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c > index 6b62898..00bb2ea 100644 > --- a/drivers/gpio/gpio-pca953x.c > +++ b/drivers/gpio/gpio-pca953x.c > @@ -129,7 +129,6 @@ struct pca953x_chip { >   struct i2c_client *client; >   struct gpio_chip gpio_chip; >   const char *const *names; > - int chip_type; >   unsigned long driver_data; >   >   const struct pca953x_offset *offset; > @@ -760,8 +759,6 @@ static int pca953x_probe(struct i2c_client > *client, >   } >   } >   > - chip->chip_type = PCA_CHIP_TYPE(chip->driver_data); > - >   mutex_init(&chip->i2c_lock); >   >   /* initialize cached registers from their original values. > @@ -774,7 +771,7 @@ static int pca953x_probe(struct i2c_client > *client, >   else if (chip->gpio_chip.ngpio >= 24) >   chip->write_regs = pca953x_write_regs_24; >   > - if (chip->chip_type == PCA953X_TYPE) > + if (PCA_CHIP_TYPE(chip->driver_data) == PCA953X_TYPE) >   ret = device_pca953x_init(chip, invert); >   else >   ret = device_pca957x_init(chip, invert); -- Andy Shevchenko Intel Finland Oy