From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>, Vignesh R <vigneshr@ti.com>,
Yong Li <yong.b.li@intel.com>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/5] gpio: pca953x: code refactoring
Date: Wed, 07 Sep 2016 14:36:59 +0300 [thread overview]
Message-ID: <1473248219.11323.41.camel@linux.intel.com> (raw)
In-Reply-To: <1473240297-19881-1-git-send-email-bgolaszewski@baylibre.com>
On Wed, 2016-09-07 at 11:24 +0200, Bartosz Golaszewski wrote:
> I'm working on converting the pca953x driver to using regmap, but
> since
> it's not a trivial task I figured I'd post a couple refactoring
> patches
> I did so far for 4.9.
>
> The first patch just fixes a couple coding style issues. The second
> removes a couple unnecessary switches. Last three refactor the
> read/write_regs functions to avoid if-elses by using function pointers
> to smaller, specialized routines.
>
> Tested with pca9534 and pca9535 chips.
Looks good to me overall, but please address my comments first.
>
> v1 -> v2:
> - constified the offset structures in patch 2/5
>
> Bartosz Golaszewski (5):
> gpio: pca953x: coding style fixes
> gpio: pca953x: code shrink
> gpio: pca953x: refactor pca953x_write_regs()
> gpio: pca953x: remove an unused variable
> gpio: pca953x: refactor pca953x_read_regs()
>
> drivers/gpio/gpio-pca953x.c | 270 ++++++++++++++++++++++-------------
> ---------
> 1 file changed, 136 insertions(+), 134 deletions(-)
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2016-09-07 11:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 9:24 [PATCH v2 0/5] gpio: pca953x: code refactoring Bartosz Golaszewski
2016-09-07 9:24 ` [PATCH v2 1/5] gpio: pca953x: coding style fixes Bartosz Golaszewski
2016-09-07 11:17 ` Andy Shevchenko
2016-09-07 9:24 ` [PATCH v2 2/5] gpio: pca953x: code shrink Bartosz Golaszewski
2016-09-07 9:24 ` [PATCH v2 3/5] gpio: pca953x: refactor pca953x_write_regs() Bartosz Golaszewski
2016-09-07 9:24 ` [PATCH v2 4/5] gpio: pca953x: remove an unused variable Bartosz Golaszewski
2016-09-07 11:36 ` Andy Shevchenko
2016-09-07 11:40 ` Bartosz Golaszewski
2016-09-07 12:17 ` Andy Shevchenko
2016-09-07 9:24 ` [PATCH v2 5/5] gpio: pca953x: refactor pca953x_read_regs() Bartosz Golaszewski
2016-09-07 11:35 ` Andy Shevchenko
2016-09-07 11:36 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473248219.11323.41.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=geert+renesas@glider.be \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vigneshr@ti.com \
--cc=yong.b.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).