linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Hunter, Adrian" <adrian.hunter@intel.com>
Subject: Re: Regulator probe
Date: Wed, 07 Sep 2016 17:24:01 +0300	[thread overview]
Message-ID: <1473258241.11323.83.camel@linux.intel.com> (raw)
In-Reply-To: <20160906102407.GF3950@sirena.org.uk>

On Tue, 2016-09-06 at 11:24 +0100, Mark Brown wrote:
> 
> > > Anyway if that's the case then it should all be working already
> > > then unless SFI goes down the ACPI code paths or someone changed
> > > SFI since SFI won't flag as having full costraints and therefore
> > > any missing regulator will report as deferring.
> 
> > 
> > But it's a real burden to describe in platform code _every_
> > regulators that device driver may need (for example, "vqmmc" is
> > optional and even "vmmc" is optional for 2 out of 3 SDHCI host
> > controllers!).
> 
> Nothing says you have to describe all regulators, you just need to
> tell the core you have told it about everything you're going to tell
> it about.  Until you do that the core has to assume that something may
> come along later and describe that supply.
> 

That's I would like to make work. For now we have fixed voltage
regulator which returns EPROBE_DEFER since GPIO IP is not initialized
yet at that point. But regulator framework decides that it's not
possible case and overrides the error code.

For me it still looks that regulator framework would not intercept
deferred regulators in case of full constraints. Feels like I'm missing
something...

> > > > Basically you mean we have not call
> > > > regulator_has_full_constraints()? In that case we have to
> > > > provide stubs for all expected regulators, in case of SDHCI one
> > > > real and one dummy, who knows how many them in the drivers, but
> > > > for each we have to provide that. Am I right?

> > > You have to either not call regulator_has_full_constraints() or
> > > supply all the mappings for device supplies before you register a
> > > device.  If you don't call regulator_has_full_constraints()
> > > missing regulators will always defer so you would need to provide
> > > a fixed voltage regulator for it.

...and fixed regulator is also deferred due to GPIO is not ready _yet_.


-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2016-09-07 14:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01 14:53 Regulator probe Andy Shevchenko
2016-09-01 15:38 ` Mark Brown
2016-09-01 16:15   ` Andy Shevchenko
2016-09-01 17:02     ` Mark Brown
2016-09-05 16:01       ` Andy Shevchenko
2016-09-06 10:24         ` Mark Brown
2016-09-07 14:24           ` Andy Shevchenko [this message]
2016-09-09 12:17             ` Mark Brown
2016-09-09 12:55               ` Andy Shevchenko
2016-09-09 15:29                 ` Mark Brown
2016-09-09 16:10                   ` Andy Shevchenko
2016-09-09 16:38                     ` Mark Brown
2016-09-09 17:04                       ` Andy Shevchenko
2016-09-09 17:18                         ` Mark Brown
2016-09-10 11:03                       ` Andy Shevchenko
2016-09-12 15:27                         ` Mark Brown
2016-09-12 16:01                           ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473258241.11323.83.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=adrian.hunter@intel.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).