From: vadimp@mellanox.com
To: rpurdie@rpsys.net, j.anaszewski@samsung.com
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
jiri@resnulli.us, michaelsh@mellanox.com,
Vadim Pasternak <vadimp@mellanox.com>
Subject: [patch 2/2] leds: add driver for Mellanox systems leds
Date: Wed, 7 Sep 2016 14:53:15 +0000 [thread overview]
Message-ID: <1473259995-196607-1-git-send-email-vadimp@mellanox.com> (raw)
From: Vadim Pasternak <vadimp@mellanox.com>
Fix in comments 3KHz and 6KHz to 3Hz and 6Hz respectively.
Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
---
drivers/leds/leds-mlxcpld.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/leds/leds-mlxcpld.c b/drivers/leds/leds-mlxcpld.c
index 0ec2375..eeed35c 100644
--- a/drivers/leds/leds-mlxcpld.c
+++ b/drivers/leds/leds-mlxcpld.c
@@ -47,8 +47,8 @@
#define MLXPLAT_CPLD_LPC_REG_BASE_ADRR 0x2500 /* LPC bus access */
/* Color codes for leds */
-#define LED_OFFSET_HALF 0x01 /* Offset from solid for 3KHz blink */
-#define LED_OFFSET_FULL 0x02 /* Offset from solid for 6KHz blink */
+#define LED_OFFSET_HALF 0x01 /* Offset from solid for 3Hz blink */
+#define LED_OFFSET_FULL 0x02 /* Offset from solid for 6Hz blink */
#define LED_IS_OFF 0x00 /* Off */
#define LED_RED_STATIC_ON 0x05 /* Solid red */
#define LED_RED_BLINK_HALF (LED_RED_STATIC_ON + LED_OFFSET_HALF)
@@ -237,7 +237,7 @@ static void mlxcpld_led_store_hw(u8 mask, u8 off, u8 vset)
/* Each led is controlled through low or high nibble of the relevant
* CPLD register. Register offset is specified by off parameter.
* Parameter vset provides color code: 0x0 for off, 0x5 for solid red,
- * 0x6 for 3KHz blink red, 0xd for solid green, 0xe for 3KHz blink
+ * 0x6 for 3Hz blink red, 0xd for solid green, 0xe for 3Hz blink
* green.
* Parameter mask specifies which nibble is used for specific led: mask
* 0xf0 - lower nibble is to be used (bits from 0 to 3), mask 0x0f -
@@ -274,8 +274,8 @@ static int mlxcpld_led_blink(struct led_classdev *led,
{
struct mlxcpld_led_priv *pled = cdev_to_priv(led);
- /* HW supports two types of blinking: full (6KHz) and half (3KHz).
- * For delay on/off zero default setting 3KHz is used.
+ /* HW supports two types of blinking: full (6Hz) and half (3Hz).
+ * For delay on/off zero default setting 3Hz is used.
*/
if (!(*delay_on == 0 && *delay_off == 0) &&
!(*delay_on == LED_BLINK_3HZ && *delay_off == LED_BLINK_3HZ) &&
--
2.1.4
next reply other threads:[~2016-09-07 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 14:53 vadimp [this message]
2016-09-07 13:10 ` [patch 2/2] leds: add driver for Mellanox systems leds Jacek Anaszewski
2016-09-07 13:39 ` Vadim Pasternak
2016-09-07 13:46 ` Jacek Anaszewski
2016-09-07 20:21 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473259995-196607-1-git-send-email-vadimp@mellanox.com \
--to=vadimp@mellanox.com \
--cc=j.anaszewski@samsung.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=michaelsh@mellanox.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).