From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759036AbcIHKt2 (ORCPT ); Thu, 8 Sep 2016 06:49:28 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37552 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752029AbcIHKsd (ORCPT ); Thu, 8 Sep 2016 06:48:33 -0400 From: Bartosz Golaszewski To: Linus Walleij , Alexandre Courbot , Andy Shevchenko , Vignesh R , Yong Li , Geert Uytterhoeven Cc: linux-gpio , LKML , Bartosz Golaszewski Subject: [PATCH v5 0/6] gpio: pca953x: code refactoring Date: Thu, 8 Sep 2016 12:48:16 +0200 Message-Id: <1473331702-26711-1-git-send-email-bgolaszewski@baylibre.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I'm working on converting the pca953x driver to using regmap, but since it's not a trivial task I figured I'd post a couple refactoring patches I did so far for 4.9. The first patch just fixes a couple coding style issues. The second removes a couple unnecessary switches. Last three refactor the read/write_regs functions to avoid if-elses by using function pointers to smaller, specialized routines. Tested with pca9534 and pca9535 chips. v1 -> v2: - constified the offset structures in patch 2/5 v2 -> v3: - modified the order of the patches so that minor coding style fixes no longer create noise for the later changes - moved the **_write_regs_16() assignments to where other variants are assigned v3 -> v4: - minor style fixes v4 -> v5: - added a patch making the register offset names consistent - bunch of style changes in patch 5/6 - renamed the structure containing the register offsets Bartosz Golaszewski (6): gpio: pca953x: code shrink gpio: pca953x: refactor pca953x_write_regs() gpio: pca953x: refactor pca953x_read_regs() gpio: pca953x: remove an unused variable gpio: pca953x: coding style fixes gpio: pca953x: make the define names consistent drivers/gpio/gpio-pca953x.c | 284 ++++++++++++++++++++++---------------------- 1 file changed, 143 insertions(+), 141 deletions(-) -- 2.7.4