From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965066AbcIHNNb (ORCPT ); Thu, 8 Sep 2016 09:13:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:54710 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932463AbcIHNN3 (ORCPT ); Thu, 8 Sep 2016 09:13:29 -0400 Message-ID: <1473340092.32073.4.camel@suse.com> Subject: Re: [PATCH net-next 0/3] r8152: configuration setting From: Oliver Neukum To: Hayes Wang Cc: bjorn@mork.no, nic_swsd , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" Date: Thu, 08 Sep 2016 15:08:12 +0200 In-Reply-To: <0835B3720019904CB8F7AA43166CEEB201026170@RTITMBSV03.realtek.com.tw> References: <1394712342-15778-215-Taiwan-albertk@realtek.com> <87h99rizsi.fsf@miraculix.mork.no> <0835B3720019904CB8F7AA43166CEEB2010259B5@RTITMBSV03.realtek.com.tw> <87vay6hlmc.fsf@miraculix.mork.no> <0835B3720019904CB8F7AA43166CEEB201026170@RTITMBSV03.realtek.com.tw> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-09-08 at 13:02 +0000, Hayes Wang wrote: > I tested above method before. And I found that the cdc_ether > was loaded before switching the configuration. The behavior > of loading one driver and changing to another driver has > opportunity to let our some previous chips become abnormal. > To switch configuration is fine. However, it may have problem > to switch driver. That is why the current kernel only supports > vendor mode. If the method works fine, I have no trouble now. We may talk about creating extensions to cdc-ether, if they are needed for the phy. What is unacceptable is to override the configuration mechanism in the kernel. Regards Oliver