From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752319AbcIII0g convert rfc822-to-8bit (ORCPT ); Fri, 9 Sep 2016 04:26:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54580 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbcIII0e (ORCPT ); Fri, 9 Sep 2016 04:26:34 -0400 Message-ID: <1473409591.6698.81.camel@redhat.com> Subject: Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. From: Gerd Hoffmann To: Stefan Wahren Cc: Mark Rutland , devicetree@vger.kernel.org, Florian Fainelli , Scott Branden , Ray Jui , Russell King , open list , Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Date: Fri, 09 Sep 2016 10:26:31 +0200 In-Reply-To: <429647ef-ff1e-4999-5b19-3b4529ad3872@i2se.com> References: <1473244289-20728-1-git-send-email-kraxel@redhat.com> <1473244289-20728-5-git-send-email-kraxel@redhat.com> <87650770.23554.026b1e4b-e35d-48e6-9394-7eeea0ff9add.open-xchange@email.1und1.de> <1473320687.6698.25.camel@redhat.com> <429647ef-ff1e-4999-5b19-3b4529ad3872@i2se.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 09 Sep 2016 08:26:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > No, i thought of the GPIO pull up/down register values: > > BCM2835_PUD_OFF 0 > BCM2835_PUD_DOWN 1 > BCM2835_PUD_UP 2 We can do that, sure (and probably drop the unused "enum bcm2835_pinconf_pull" from drivers/pinctrl/bcm/pinctrl-bcm2835.c at the same time). But I fail to see how this is related to the patch discussed, looks like a independent issue to me ... cheers, Gerd