From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752895AbcIIQPH (ORCPT <rfc822;w@1wt.eu>);
        Fri, 9 Sep 2016 12:15:07 -0400
Received: from smtprelay0145.hostedemail.com ([216.40.44.145]:50580 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751008AbcIIQPF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 9 Sep 2016 12:15:05 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1537:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3871:3872:3874:4321:5007:10004:10400:10848:11232:11658:11914:12048:12663:12740:13069:13311:13357:13439:14659:14721:21080:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: hook42_662135e549a12
X-Filterd-Recvd-Size: 1451
Message-ID: <1473437700.13672.43.camel@perches.com>
Subject: Re: [PATCH 3/5] nbd: use flags instead of bool
From: Joe Perches <joe@perches.com>
To: Jens Axboe <axboe@fb.com>, Josef Bacik <jbacik@fb.com>,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-team@fb.com, mpa@pengutronix.de,
        nbd-general@lists.sourceforge.net
Date: Fri, 09 Sep 2016 09:15:00 -0700
In-Reply-To: <9ddc6c54-72cd-b3d4-d7f3-f96dc33164fc@fb.com>
References: <1473369130-22986-1-git-send-email-jbacik@fb.com>
         <1473369130-22986-4-git-send-email-jbacik@fb.com>
         <1473384038.13672.23.camel@perches.com>
         <bda72452-8a5f-8a6a-2409-145585ea41f5@fb.com>
         <1473437068.13672.41.camel@perches.com>
         <9ddc6c54-72cd-b3d4-d7f3-f96dc33164fc@fb.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.21.91-0ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2016-09-09 at 10:11 -0600, Jens Axboe wrote:
> The variable is called 'runtime_flags' - if that doesn't already tell
> the reader how it's used, then I'd suggest the reader go read something
> else.
> 
> I'm all for using established APIs where it makes sense. Declaring a
> bitmap for a few fields isn't that.

Deviating from established APIs makes no sense.