From: David Howells <dhowells@redhat.com>
To: netdev@vger.kernel.org
Cc: dhowells@redhat.com, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next 02/10] rxrpc: Add missing wakeup on Tx window rotation
Date: Tue, 13 Sep 2016 23:21:10 +0100 [thread overview]
Message-ID: <147380527029.23135.18355783643218711122.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <147380525614.23135.7539695651371953351.stgit@warthog.procyon.org.uk>
We need to wake up the sender when Tx window rotation due to an incoming
ACK makes space in the buffer otherwise the sender is liable to just hang
endlessly.
This problem isn't noticeable if the Tx phase transfers no more than will
fit in a single window or the Tx window rotates fast enough that it doesn't
get full.
Signed-off-by: David Howells <dhowells@redhat.com>
---
net/rxrpc/input.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/rxrpc/input.c b/net/rxrpc/input.c
index afeba98004b1..a707d5952164 100644
--- a/net/rxrpc/input.c
+++ b/net/rxrpc/input.c
@@ -59,6 +59,8 @@ static void rxrpc_rotate_tx_window(struct rxrpc_call *call, rxrpc_seq_t to)
spin_unlock(&call->lock);
+ wake_up(&call->waitq);
+
while (list) {
skb = list;
list = skb->next;
next prev parent reply other threads:[~2016-09-13 22:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 22:20 [PATCH net-next 00/10] rxrpc: Miscellaneous fixes David Howells
2016-09-13 22:21 ` [PATCH net-next 01/10] rxrpc: Make sure we initialise the peer hash key David Howells
2016-09-13 22:21 ` David Howells [this message]
2016-09-13 22:21 ` [PATCH net-next 03/10] rxrpc: The IDLE ACK packet should use rxrpc_idle_ack_delay David Howells
2016-09-13 22:21 ` [PATCH net-next 04/10] rxrpc: Requeue call for recvmsg if more data David Howells
2016-09-13 22:21 ` [PATCH net-next 05/10] rxrpc: Add missing unlock in rxrpc_call_accept() David Howells
2016-09-13 22:21 ` [PATCH net-next 06/10] rxrpc: Use skb->len not skb->data_len David Howells
2016-09-13 22:21 ` [PATCH net-next 07/10] rxrpc: Allow tx_winsize to grow in response to an ACK David Howells
2016-09-13 22:21 ` [PATCH net-next 08/10] rxrpc: Adjust the call ref tracepoint to show kernel API refs David Howells
2016-09-13 22:21 ` [PATCH net-next 09/10] rxrpc: Fix prealloc refcounting David Howells
2016-09-13 22:22 ` [PATCH net-next 10/10] rxrpc: Correctly initialise, limit and transmit call->rx_winsize David Howells
2016-09-16 5:55 ` [PATCH net-next 00/10] rxrpc: Miscellaneous fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=147380527029.23135.18355783643218711122.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).