From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759957AbcIQBQK (ORCPT ); Fri, 16 Sep 2016 21:16:10 -0400 Received: from mail-he1eur01on0102.outbound.protection.outlook.com ([104.47.0.102]:32672 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755647AbcIQBQG (ORCPT ); Fri, 16 Sep 2016 21:16:06 -0400 X-Greylist: delayed 39765 seconds by postgrey-1.27 at vger.kernel.org; Fri, 16 Sep 2016 21:16:05 EDT From: Marcel Ziswiler To: "shawnguo@kernel.org" , "maitysanchayan@gmail.com" CC: "stefan@agner.ch" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v1 1/3] ARM: dts: imx6qdl-apalis: Do not rely on DDC I2C bus bitbang for HDMI Thread-Topic: [PATCH v1 1/3] ARM: dts: imx6qdl-apalis: Do not rely on DDC I2C bus bitbang for HDMI Thread-Index: AQHSDlNEjCY9CYsQdUGO7yNp26xuKKB8IpYA Date: Fri, 16 Sep 2016 13:38:35 +0000 Message-ID: <1474033114.3103.25.camel@toradex.com> References: <9d2c17aa2e00e6ff4349a53de8247860d2382607.1473833908.git.maitysanchayan@gmail.com> In-Reply-To: <9d2c17aa2e00e6ff4349a53de8247860d2382607.1473833908.git.maitysanchayan@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=marcel.ziswiler@toradex.com; x-originating-ip: [84.227.37.153] x-ms-office365-filtering-correlation-id: d351e901-4227-455b-fee1-08d3de36c23c x-microsoft-exchange-diagnostics: 1;HE1PR05MB1881;6:Qbo7ZsnKtansFnzFW0XFUknnI3QB3jDAaNj0U29OcQT9IDYWAp5H01FujLA3O0SR0XZ08MkWHbV/jNW1g7j/cQ9h4o7WuXPIFAaBaKi3ECpNKlHpwc2NLlBb1oZSi4PxrqCgoN/7gYZlu4DgcFeMGusZIUSB3J2cx3fHT6vWd9A49AltasEX79WoPc2kRXX+fS/7vmruyvOVLOwgHnTlFm6EK4fXjwNL4ZOKyvN6cU30oUPpqfRPniJ5S6Q5GmnMYrv1cLXKuBNEj0tJHCxbaM86chmYv6FA7RrZEYFn3mc=;5:u3c40Rm0Q7U0UMWlx7DNQk2fXKLcgvVfqex8601jqi7KDcFaYB0TEnqydZIURqOiMUFJ7XIZEOk2xU4N0c4IWDMrcvLZyBsDzya0BPXYryCHLRIFeAgQGgcDSxfmbRcBgcC2TeeVMrdz3smItnjMpA==;24:w09cG7o2E1WG49ju8EjOoTEgomdzT8jnV1b0bs0spFcoN4OqUXfSeJX71C0VxSRxInDP1czFnH9zajDNq7+byNzDlLqqMrDQOSHV6jttMTQ=;7:sTByrRnDLv4ukPC2aF7rgOkvvI+W6hvMw4jCvVWuRebjchgl9Rp+2+n+t4DVDeaRRPK+IpxGbxw8Gu1T/itUJjziVctOZYyherzd4sL/Ii9Cfc+7sEiI5diXQkZ9KXIp9x/aeYMZMU6ooY0HBUF05WpFxfOeYcV1/dDQu7jaDrQVvCmWqIdGbbxXAgb/VHJGR60C5027x491lznPjueoEYFlHLUPvAcJ0YUuRitd9qxXCaen/LcxR/gN7452fX+V x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1881; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:HE1PR05MB1881;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1881; x-forefront-prvs: 0067A8BA2A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(377424004)(199003)(189002)(24454002)(5002640100001)(189998001)(3280700002)(19580405001)(575784001)(2906002)(92566002)(4326007)(305945005)(8936002)(122556002)(36756003)(87936001)(7846002)(2501003)(7736002)(86362001)(19580395003)(5660300001)(2950100001)(2900100001)(8676002)(101416001)(106116001)(81166006)(6116002)(54356999)(106356001)(76176999)(10400500002)(77096005)(105586002)(81156014)(103116003)(3846002)(97736004)(5001770100001)(68736007)(66066001)(586003)(33646002)(102836003)(15975445007)(3660700001)(50986999)(32563001);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR05MB1881;H:HE1PR05MB1882.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2016 13:38:35.5587 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1881 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u8H1GYFa015990 On Wed, 2016-09-14 at 12:05 +0530, Sanchayan Maity wrote: > Remove the use of DDC I2C bus bitbang to support reading of EDID > and rely on support from internal HDMI I2C master controller instead. > As a result remove the device tree property ddc-i2c-bus. > > Signed-off-by: Sanchayan Maity > --- > Hello, > > This patch is tested with the following patch applied > https://patchwork.kernel.org/patch/9296883/ > > and is based on the suggestions from Vladimir > https://lkml.org/lkml/2016/8/29/322 > > This and following two patches are based on top of shawn's > for-next branch. > > Regards, > Sanchayan. > --- >  arch/arm/boot/dts/imx6q-apalis-ixora.dts |  6 ------ >  arch/arm/boot/dts/imx6qdl-apalis.dtsi    | 25 +++++++++------------- > --- >  2 files changed, 9 insertions(+), 22 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6q-apalis-ixora.dts > b/arch/arm/boot/dts/imx6q-apalis-ixora.dts > index 207b85b..d99979e 100644 > --- a/arch/arm/boot/dts/imx6q-apalis-ixora.dts > +++ b/arch/arm/boot/dts/imx6q-apalis-ixora.dts > @@ -55,7 +55,6 @@ >        "fsl,imx6q"; >   >   aliases { > - i2c0 = &i2cddc; >   i2c1 = &i2c1; >   i2c2 = &i2c2; >   i2c3 = &i2c3; I would suggest rising them up in rank. > @@ -186,11 +185,6 @@ >  }; >   >  &hdmi { > - ddc-i2c-bus = <&i2cddc>; > - status = "okay"; > -}; > - > -&i2cddc { >   status = "okay"; >  }; >   > diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi > b/arch/arm/boot/dts/imx6qdl-apalis.dtsi > index 99e323b..8c67dd8 100644 > --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi > @@ -53,18 +53,6 @@ >   status = "disabled"; >   }; >   > - /* DDC_I2C: I2C2_SDA/SCL on MXM3 205/207 */ > - i2cddc: i2c@0 { > - compatible = "i2c-gpio"; > - pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_i2c_ddc>; > - gpios = <&gpio3 16 GPIO_ACTIVE_HIGH /* sda */ > -  &gpio2 30 GPIO_ACTIVE_HIGH /* scl */ > - >; > - i2c-gpio,delay-us = <2>; /* ~100 kHz */ > - status = "disabled"; > - }; > - >   reg_1p8v: regulator-1p8v { >   compatible = "regulator-fixed"; >   regulator-name = "1P8V"; > @@ -209,6 +197,12 @@ >   }; >  }; >   > +&hdmi { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_hdmi_ddc>; > + status = "disabled"; > +}; > + >  /* >   * GEN1_I2C: I2C1_SDA/SCL on MXM3 209/211 (e.g. RTC on carrier >   * board) > @@ -633,11 +627,10 @@ >   >; >   }; >   > - pinctrl_i2c_ddc: gpioi2cddcgrp { > + pinctrl_hdmi_ddc: hdmiddcgrp { >   fsl,pins = < > - /* DDC bitbang */ > - MX6QDL_PAD_EIM_EB2__GPIO2_IO30 0x1b0b0 > - MX6QDL_PAD_EIM_D16__GPIO3_IO16 0x1b0b0 > + MX6QDL_PAD_EIM_EB2__HDMI_TX_DDC_SCL > 0x4001b8b1 > + MX6QDL_PAD_EIM_D16__HDMI_TX_DDC_SDA > 0x4001b8b1 >   >; >   };   Rest looks fine and tested working fine on top of 4.8.0-rc6-next-20160916.