From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Yangbo Lu" <yangbo.lu@nxp.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Xiaobo Xie" <xiaobo.xie@nxp.com>,
"Minghuan Lian" <minghuan.lian@nxp.com>,
linux-i2c@vger.kernel.org, linux-clk@vger.kernel.org,
"Qiang Zhao" <qiang.zhao@nxp.com>,
"Russell King" <linux@arm.linux.org.uk>,
"Bhupesh Sharma" <bhupesh.sharma@freescale.com>,
"Joerg Roedel" <joro@8bytes.org>,
"Jochen Friedrich" <jochen@scram.de>,
"Claudiu Manoil" <claudiu.manoil@freescale.com>,
devicetree@vger.kernel.org, "Kumar Gala" <galak@codeaurora.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Santosh Shilimkar" <ssantosh@kernel.org>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, "Leo Li" <leoyang.li@nxp.com>,
iommu@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
linux-mmc@vger.kernel.org, ulf.hansson@linaro.org,
"Scott Wood" <oss@buserror.net>, "Arnd Bergmann" <arnd@arndb.de>
Subject: Re: [v12, 7/8] base: soc: introduce soc_device_match() interface
Date: Wed, 21 Sep 2016 10:56:14 +0300 [thread overview]
Message-ID: <1474444574.270880035@f136.i.mail.ru> (raw)
In-Reply-To: <1474441040-11946-8-git-send-email-yangbo.lu@nxp.com>
>Среда, 21 сентября 2016, 9:57 +03:00 от Yangbo Lu <yangbo.lu@nxp.com>:
>
>From: Arnd Bergmann < arnd@arndb.de >
>
>We keep running into cases where device drivers want to know the exact
>version of the a SoC they are currently running on. In the past, this has
>usually been done through a vendor specific API that can be called by a
>driver, or by directly accessing some kind of version register that is
>not part of the device itself but that belongs to a global register area
>of the chip.
...
>+const struct soc_device_attribute *soc_device_match(
>+const struct soc_device_attribute *matches)
>+{
>+int ret = 0;
>+
>+if (!matches)
>+return NULL;
>+
>+while (!ret) {
>+if (!(matches->machine || matches->family ||
>+ matches->revision || matches->soc_id))
>+break;
>+ret = bus_for_each_dev(&soc_bus_type, NULL, (void *)matches,
>+ soc_device_match_one);
>+if (!ret)
>+matches++;
So, what happen if next "matches" (after increment) will be NULL?
I think you should use while(matches) at the start of this procedure.
---
next prev parent reply other threads:[~2016-09-21 7:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 6:57 [v12, 0/8] Fix eSDHC host version register bug Yangbo Lu
2016-09-21 6:57 ` [v12, 1/8] dt: bindings: update Freescale DCFG compatible Yangbo Lu
2016-09-21 6:57 ` [v12, 2/8] ARM64: dts: ls2080a: add device configuration node Yangbo Lu
2016-09-21 6:57 ` [v12, 3/8] dt: bindings: move guts devicetree doc out of powerpc directory Yangbo Lu
2016-09-21 6:57 ` [v12, 4/8] powerpc/fsl: move mpc85xx.h to include/linux/fsl Yangbo Lu
2016-09-21 6:57 ` [v12, 5/8] soc: fsl: add GUTS driver for QorIQ platforms Yangbo Lu
2016-10-26 17:06 ` Scott Wood
2016-10-27 4:34 ` Y.B. Lu
2016-09-21 6:57 ` [v12, 6/8] MAINTAINERS: add entry for Freescale SoC drivers Yangbo Lu
2016-09-21 6:57 ` [v12, 7/8] base: soc: introduce soc_device_match() interface Yangbo Lu
2016-09-21 7:56 ` Alexander Shiyan [this message]
2016-09-21 8:25 ` Peter Rosin
2016-09-21 6:57 ` [v12, 8/8] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0 Yangbo Lu
2016-09-26 3:14 ` [v12, 0/8] Fix eSDHC host version register bug Y.B. Lu
2016-10-08 3:28 ` Y.B. Lu
2016-10-18 10:47 ` Ulf Hansson
2016-10-19 2:40 ` Y.B. Lu
2016-10-19 2:47 ` Y.B. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474444574.270880035@f136.i.mail.ru \
--to=shc_work@mail.ru \
--cc=arnd@arndb.de \
--cc=bhupesh.sharma@freescale.com \
--cc=claudiu.manoil@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jochen@scram.de \
--cc=joro@8bytes.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=minghuan.lian@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=oss@buserror.net \
--cc=qiang.zhao@nxp.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=xiaobo.xie@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).