From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940978AbcJGQZm (ORCPT ); Fri, 7 Oct 2016 12:25:42 -0400 Received: from smtprelay0235.hostedemail.com ([216.40.44.235]:42439 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S938833AbcJGQZc (ORCPT ); Fri, 7 Oct 2016 12:25:32 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1543:1593:1594:1605:1711:1730:1747:1777:1792:2393:2559:2562:2828:2893:2897:2914:2915:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3871:4250:4321:4384:5007:6119:6120:6742:7903:8603:10004:10400:10848:11026:11658:11914:12043:12296:12438:12740:12760:13439:14659:14721:21080:21433:21451:30003:30009:30029:30030:30034:30045:30051:30054:30056:30064:30069:30075:30080:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: berry65_4cef443cfa006 X-Filterd-Recvd-Size: 4858 Message-ID: <1475857527.1945.7.camel@perches.com> Subject: Re: [RFC 1/2] staging: jnx: Add Juniper connector driver From: Joe Perches To: Pantelis Antoniou , Rob Herring , Mark Rutland Cc: Frank Rowand , Greg Kroah-Hartman , Alon Ronen , Debjit Ghosh , Dhruva Diveneni , Georgi Vlaev , Guenter Roeck , Yu-Lin Lu , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Date: Fri, 07 Oct 2016 09:25:27 -0700 In-Reply-To: <1475853372-21997-2-git-send-email-pantelis.antoniou@konsulko.com> References: <1475853372-21997-1-git-send-email-pantelis.antoniou@konsulko.com> <1475853372-21997-2-git-send-email-pantelis.antoniou@konsulko.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.0-2ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-10-07 at 18:16 +0300, Pantelis Antoniou wrote: > diff --git a/drivers/staging/jnx/jnx-connector.c b/drivers/staging/jnx/jnx-connector.c [] > +struct jnx_conn_data { > + struct device *dev; /* parent (platform) device */ > + const char *name[NUM_OVERLAYS]; /* overlay file names */ > + bool enabled; /* true if can handle interrupts */ > + bool poweron; /* true if assumed to be powered on */ maybe use pahole and remove some of the wasteful padding > + int attention_button; /* attention button gpio pin */ > + bool have_attention_button; /* true if attention button exists */ > + unsigned long attention_button_holdtime;/* button hold time, jiffies */ > + bool attention_ignore; /* true if handled by user space */ > + int power_enable; /* power enable gpio pin */ > + bool auto_enable; /* true if board should auto-enable */ > + struct jnx_i2c_power_seq pon; /* power-on sequence */ [] > + u32 gpio_flags; > + u16 assembly_id; > + int slot; /* slot number */ > + int type; /* card type */ > + bool static_assembly_id; /* true if assembly_id is static */ > + bool assembly_id_valid; /* true if assembly_id is valid */ > + int adapter; /* parent i2c adapter number */ [] > + struct mutex mutex; /* mutex to protect state changes */ > + bool synchronous; /* true if state changes are ok */ > + struct mutex fdt_mutex; /* mutex to protect fdt accesses */ [] > + bool standby_to_master; /* standby:master_ev processing */ > +}; [] > +/* > + * jnx_conn_insert_ideeprom() > + * Inserts ideeprom with a parent from OF prop > + */ > +static int jnx_conn_insert_ideeprom(struct jnx_conn_data *data, > + struct i2c_adapter *adap, > + struct device_node *node, > + struct i2c_board_info *info) > +{ > + struct device *dev = data->dev; > + struct i2c_adapter *parent = NULL; > + struct i2c_client *client; > + struct device_node *anode; > + struct at24_platform_data at24_pdata = { > + .byte_len = 256, > + .page_size = 4, > + .setup = jnx_conn_at24_callback, > + .context = data, > + }; > + > + info->platform_data = &at24_pdata; Assigning a temporary address through a pointer argument? Isn't there a better way? > +/* > + * jnx_conn_verify_overlay() > + * > + * Verify if overlay is compatible with this board/slot > + */ > +static int jnx_conn_verify_overlay(struct jnx_conn_data *data, > + struct device_node *np) > +{ [] > + ret = of_property_read_u32(np, "type", &var); > + if (ret) { > + dev_err(dev, "Missing type property\n"); > + return ret; > + } > + if (var != data->type) { > + dev_err(dev, "Wrong type: Expected %d, got %d\n", > + data->type, var); > + return -EINVAL; > + } > + > + /* > + * 'assembly-ids' property must exist, and one of its entries must match > + * the card assembly id > + */ > + assembly_ids = of_get_property(np, "assembly-ids", &size); > + if (!assembly_ids || size < sizeof(u32)) { > + dev_err(dev, "Bad assembly-ids property\n"); > + return -EINVAL; > + } > + ret = -EINVAL; > + for (i = 0; i < size / sizeof(u32); i++) { > + if (be32_to_cpu(assembly_ids[i]) == data->assembly_id) { > + ret = 0; > + break; > + } > + } > + if (ret) { > + dev_err(dev, "Assembly ID 0x%x not supported by overlay\n", > + data->assembly_id); > + return ret; > + } Given all the direct returns above here, perhaps for (i = 0; i < size / sizeof(u32); i++) { if (be32_to_cpu(assembly_ids[i]) == data->assembly_id) return 0; } dev_err(...); return -EINVAL;