From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753224AbcJMJaG (ORCPT ); Thu, 13 Oct 2016 05:30:06 -0400 Received: from smtprelay0165.hostedemail.com ([216.40.44.165]:44584 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752938AbcJMJaA (ORCPT ); Thu, 13 Oct 2016 05:30:00 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:967:973:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2525:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3742:3865:3866:3867:3868:3870:3871:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6691:9007:9025:10004:10400:10482:10848:11232:11257:11658:11914:12043:12296:12438:12555:12740:12783:13069:13208:13229:13311:13357:13439:13846:13894:14180:14181:14659:14721:14849:19901:19997:21067:21080:21433,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: smoke61_8fc27ee9acf08 X-Filterd-Recvd-Size: 2322 Message-ID: <1476350986.2164.3.camel@perches.com> Subject: Re: linux.git: printk() problem From: Joe Perches To: Michal Hocko Cc: Tetsuo Handa , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, Colin Ian King Date: Thu, 13 Oct 2016 02:29:46 -0700 In-Reply-To: <20161013062600.GB21678@dhcp22.suse.cz> References: <201610122230.DID43237.FSOHFFQOJOtVML@I-love.SAKURA.ne.jp> <20161012143525.GD9523@dhcp22.suse.cz> <1476288538.16823.9.camel@perches.com> <20161013062600.GB21678@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.0-2ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-10-13 at 08:26 +0200, Michal Hocko wrote: > On Wed 12-10-16 09:08:58, Joe Perches wrote: > > On Wed, 2016-10-12 at 16:35 +0200, Michal Hocko wrote: > > > On Wed 12-10-16 22:30:03, Tetsuo Handa wrote: > > > > Hello. > > > > > > > > I noticed that current linux.git generates hardly readable console output > > > > due to KERN_CONT changes. Are you suggesting developers that output like > > > > this be fixed? > > > > > > > > > > > > Joe has already posted a patch > > > http://lkml.kernel.org/r/c7df37c8665134654a17aaeb8b9f6ace1d6db58b.1476239034.git.joe@perches.com > > > > > > And in general I think that adding those KERN_CONT is a good thing to > > > do. > > > > > > As do I, but there are about a quarter _million_ uses of > > printk/logging messages in the kernel tree with newlines. > > > > Maybe 100 or so of the existing messages lack terminating > > newlines. > > > I think they are not critical and can be fix once somebody notices. As do I, but Linus objected to applying a patch when Colin Ian King noticed one. I think the 250,000 or so uses with newlines are enough of a precedence to keep using newlines everywhere. Now we'll have to have patches adding hundreds to thousands of the missing KERN_CONTs for continuation lines that weren't previously a problem in logging output but are now.