* [PATCH] checkpatch: don't try to get maintained status when --no-tree is given
@ 2016-10-17 15:55 Jerome Forissier
2016-10-17 16:56 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Jerome Forissier @ 2016-10-17 15:55 UTC (permalink / raw)
To: Andy Whitcroft, Joe Perches, linux-kernel; +Cc: Jerome Forissier
Fixes the following warning:
Use of uninitialized value $root in concatenation (.) or string at /path/to/checkpatch.pl line 764.
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a8368d1..aa694bc 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -761,7 +761,7 @@ sub seed_camelcase_file {
sub is_maintained_obsolete {
my ($filename) = @_;
- return 0 if (!(-e "$root/scripts/get_maintainer.pl"));
+ return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));
my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] checkpatch: don't try to get maintained status when --no-tree is given
2016-10-17 15:55 [PATCH] checkpatch: don't try to get maintained status when --no-tree is given Jerome Forissier
@ 2016-10-17 16:56 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2016-10-17 16:56 UTC (permalink / raw)
To: Jerome Forissier, Andy Whitcroft, linux-kernel; +Cc: Andrew Morton
On Mon, 2016-10-17 at 17:55 +0200, Jerome Forissier wrote:
> Fixes the following warning:
> Use of uninitialized value $root in concatenation (.) or string at /path/to/checkpatch.pl line 764.
Thanks Jerome.
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Joe Perches <joe@perches.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a8368d1..aa694bc 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -761,7 +761,7 @@ sub seed_camelcase_file {
> sub is_maintained_obsolete {
> my ($filename) = @_;
>
> - return 0 if (!(-e "$root/scripts/get_maintainer.pl"));
> + return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));
>
> my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-17 17:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-17 15:55 [PATCH] checkpatch: don't try to get maintained status when --no-tree is given Jerome Forissier
2016-10-17 16:56 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).