linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jerome Forissier <jerome.forissier@linaro.org>,
	Andy Whitcroft <apw@canonical.com>,
	linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] checkpatch: don't try to get maintained status when --no-tree is given
Date: Mon, 17 Oct 2016 09:56:11 -0700	[thread overview]
Message-ID: <1476723371.1973.3.camel@perches.com> (raw)
In-Reply-To: <1476719709-16668-1-git-send-email-jerome.forissier@linaro.org>

On Mon, 2016-10-17 at 17:55 +0200, Jerome Forissier wrote:
> Fixes the following warning:
> Use of uninitialized value $root in concatenation (.) or string at /path/to/checkpatch.pl line 764.

Thanks Jerome.

> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>

Acked-by: Joe Perches <joe@perches.com>

> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a8368d1..aa694bc 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -761,7 +761,7 @@ sub seed_camelcase_file {
>  sub is_maintained_obsolete {
>  	my ($filename) = @_;
>  
> -	return 0 if (!(-e "$root/scripts/get_maintainer.pl"));
> +	return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));
>  
>  	my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;

      reply	other threads:[~2016-10-17 17:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 15:55 [PATCH] checkpatch: don't try to get maintained status when --no-tree is given Jerome Forissier
2016-10-17 16:56 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476723371.1973.3.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=jerome.forissier@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).