From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756696AbcJTHZU (ORCPT ); Thu, 20 Oct 2016 03:25:20 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:23917 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752274AbcJTHXj (ORCPT ); Thu, 20 Oct 2016 03:23:39 -0400 X-AuditID: cbfec7f1-f79f46d0000008eb-ae-580870f82844 From: Marek Szyprowski To: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski , Joerg Roedel , Inki Dae , Kukjin Kim , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , "Rafael J. Wysocki" , Mark Brown , "Luis R. Rodriguez" , Greg Kroah-Hartman , Tomeu Vizoso , Lukas Wunner , Kevin Hilman , Tobias Jakobi , Tomasz Figa Subject: [PATCH v5 6/7] iommu/exynos: Add runtime pm support Date: Thu, 20 Oct 2016 09:22:52 +0200 Message-id: <1476948173-21093-7-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1476948173-21093-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTYRjHfXfOzjlOjxy2YW9qflj5oZuXEnlJDaOIE1QUQYopOfSgkrc2 lQwUl3hp5QUlXKYlZc5Mm5osm5mmMi8TZ2qg1bK8ZBpmpUKmWW7Hvv2e5///P8/7vrwUJr4n dKFiE5I5RYI8TkaIcL1x1bz/VxIV4m14h6FGjU6Ibn2aJlDWAx2BiieKcFTZ7o+u32kgUeHU VwzNPJ0SILN5sxwxlBNoKb8bII35pQB9mXVF9d0WEo0VzQA0YBoWopzH34Wo1rAOUEH9MBEk Yadf3RWwLZYqwD4vs5BsU+11gm2vqCPZkjEtYDeMJNv8JhdnC5prAbvU5M5qcvXCMw6hooAo Li42lVN4HY4QxdxsHSKSKnZdqW7TCTKBwV0NKAoyvrD+s0IN7DfRGQ590BFqIKLEzEMACyxd W8USgGVzKgHv8oXmrBUBL1QDuLZRR1oFMZMpgIsjXlYmGB+oXlDb0lJGBeByXpUtgTGTOMxR 3QdWl4QJgIa5GlsaZzzg6uKMrU8zLKxRVWP8OnfYZywRWtmeOQFb6/Ix6yDIrJBQ1VEC+Evs gE0dW/5j8KdJs3VUCZzvaSZ5doMjJTdwngsBvJa9l2cNgIMLNM/+sKvntW0XxjjBYn0pxo+n YV6OmLewUD+RR/LtI3BoNox/iHIAG8y/8SLgVgnsaoGUS1HGR3PKA55KebwyJSHaMzIxvgls fhvTRs+PFrDYe6gTMBSQOdIxg2SIWChPVabFdwJIYTIpbYyjQsR0lDztKqdIvKhIieOUncCV wmXb6BeVo8FiJlqezF3iuCRO8V8VUPYumeBRmFPQ0XN/eo9rx0+dbrd4X+AGnDMcUsIvGzck XhGtiX8tC/34sl+A3nHy/O4cqYddusF0MiNx3olyFZ2dCZwaj0wvyNVZ1Kk7+9S+3RkVdn7g 4xT9Ns8ntJF+ktmWvbau3ac12mmfdQejyv5vB6Uu4XNRVculSaFLt7cHjr6X4coYuc8eTKGU /wPscHqlMgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEIsWRmVeSWpSXmKPExsVy+t/xK7qXCzgiDOb/0LHYOGM9q8XUh0/Y LJoXr2ezmHR/AovFgv3WFp2zN7Bb9D9+zWzxdPNjJovz54Hcy7vmsFl87j3CaDHj/D4mixfP pS3WHrnLbnFjwlNGizOnL7FatK3+wGqxatcfRou+tZfYHIQ9nhycx+Sx4+4SRo+ds+6ye2xa 1cnmsX/uGnaPyTeWM3r8O8buseVqO4tH35ZVjB6fN8l5zGjfxhrAHeVmk5GamJJapJCal5yf kpmXbqsUGuKma6GkkJeYm2qrFKHrGxKkpFCWmFMK5BkZoAEH5wD3YCV9uwS3jJ7dF9gK5qpU LNu7nqmBcZdcFyMnh4SAicT55q9MELaYxIV769m6GLk4hASWMErs2beDBcJpYpJ423SGBaSK TcBQouttF1iViEAjo8S2rRPZQRxmgWcsEgt+bGMDqRIWsJHY9XIFO4jNIqAq8fP9U0YQm1fA Q2JF4zJmiH1yEiePTWYFsTkFPCV2r+kFiwsB1bzfuI5xAiPvAkaGVYwiqaXFuem5xUZ6xYm5 xaV56XrJ+bmbGIHxt+3Yzy07GLveBR9iFOBgVOLhzTjHHiHEmlhWXJl7iFGCg1lJhPdYDkeE EG9KYmVValF+fFFpTmrxIUZToKMmMkuJJucDU0NeSbyhiaG5paGRsYWFuZGRkjjv1A9XwoUE 0hNLUrNTUwtSi2D6mDg4pRoYHdZy3HqU3NjfNyc2tH1K/tfpi/u6Pk1cyqu9KkZgXswa0YvO 5Y5aNX4+yrPnxrf4T/4R2mVl9fWz+/SrklOUH858fGfW9L9Xf69P2aDWZb/vZJMLh1PuRB1d 0z/vBF03T9G+mBLl9f+L8+Pgllfmpx85KdvVXDTZ1vd6/VtbR5s/D5+9Pn5BXImlOCPRUIu5 qDgRAHEJeC7VAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161020072335eucas1p209675d6fbf39e5045281e8023fa9d234 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161020072335eucas1p209675d6fbf39e5045281e8023fa9d234 X-RootMTR: 20161020072335eucas1p209675d6fbf39e5045281e8023fa9d234 References: <1476948173-21093-1-git-send-email-m.szyprowski@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch adds runtime pm implementation, which is based on previous suspend/resume code. SYSMMU controller is now being enabled/disabled mainly from the runtime pm callbacks. System sleep callbacks relies on generic pm_runtime_force_suspend/pm_runtime_force_resume helpers. To ensure internal state consistency, additional lock for runtime pm transitions was introduced. Signed-off-by: Marek Szyprowski --- drivers/iommu/exynos-iommu.c | 45 +++++++++++++++++++++++++++++++++++--------- 1 file changed, 36 insertions(+), 9 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index a959443e6f33..5e6d7bbf9b70 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -206,6 +206,7 @@ struct sysmmu_fault_info { struct exynos_iommu_owner { struct list_head controllers; /* list of sysmmu_drvdata.owner_node */ struct iommu_domain *domain; /* domain this device is attached */ + struct mutex rpm_lock; /* for runtime pm of all sysmmus */ }; /* @@ -594,40 +595,46 @@ static int __init exynos_sysmmu_probe(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM_SLEEP -static int exynos_sysmmu_suspend(struct device *dev) +static int __maybe_unused exynos_sysmmu_suspend(struct device *dev) { struct sysmmu_drvdata *data = dev_get_drvdata(dev); struct device *master = data->master; if (master) { - pm_runtime_put(dev); + struct exynos_iommu_owner *owner = master->archdata.iommu; + + mutex_lock(&owner->rpm_lock); if (data->domain) { dev_dbg(data->sysmmu, "saving state\n"); __sysmmu_disable(data); } + mutex_unlock(&owner->rpm_lock); } return 0; } -static int exynos_sysmmu_resume(struct device *dev) +static int __maybe_unused exynos_sysmmu_resume(struct device *dev) { struct sysmmu_drvdata *data = dev_get_drvdata(dev); struct device *master = data->master; if (master) { - pm_runtime_get_sync(dev); + struct exynos_iommu_owner *owner = master->archdata.iommu; + + mutex_lock(&owner->rpm_lock); if (data->domain) { dev_dbg(data->sysmmu, "restoring state\n"); __sysmmu_enable(data); } + mutex_unlock(&owner->rpm_lock); } return 0; } -#endif static const struct dev_pm_ops sysmmu_pm_ops = { - SET_LATE_SYSTEM_SLEEP_PM_OPS(exynos_sysmmu_suspend, exynos_sysmmu_resume) + SET_RUNTIME_PM_OPS(exynos_sysmmu_suspend, exynos_sysmmu_resume, NULL) + SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, + pm_runtime_force_resume) }; static const struct of_device_id sysmmu_of_match[] __initconst = { @@ -775,7 +782,15 @@ static void exynos_iommu_detach_device(struct iommu_domain *iommu_domain, return; list_for_each_entry(data, &owner->controllers, owner_node) { - __sysmmu_disable(data); + pm_runtime_put_sync(data->sysmmu); + } + + mutex_lock(&owner->rpm_lock); + + list_for_each_entry(data, &owner->controllers, owner_node) { + pm_runtime_get_noresume(data->sysmmu); + if (pm_runtime_active(data->sysmmu)) + __sysmmu_disable(data); pm_runtime_put(data->sysmmu); } @@ -790,6 +805,7 @@ static void exynos_iommu_detach_device(struct iommu_domain *iommu_domain, owner->domain = NULL; spin_unlock_irqrestore(&domain->lock, flags); + mutex_unlock(&owner->rpm_lock); dev_dbg(dev, "%s: Detached IOMMU with pgtable %pa\n", __func__, &pagetable); @@ -810,6 +826,8 @@ static int exynos_iommu_attach_device(struct iommu_domain *iommu_domain, if (owner->domain) exynos_iommu_detach_device(owner->domain, dev); + mutex_lock(&owner->rpm_lock); + spin_lock_irqsave(&domain->lock, flags); list_for_each_entry(data, &owner->controllers, owner_node) { spin_lock(&data->lock); @@ -822,8 +840,16 @@ static int exynos_iommu_attach_device(struct iommu_domain *iommu_domain, spin_unlock_irqrestore(&domain->lock, flags); list_for_each_entry(data, &owner->controllers, owner_node) { + pm_runtime_get_noresume(data->sysmmu); + if (pm_runtime_active(data->sysmmu)) + __sysmmu_enable(data); + pm_runtime_put(data->sysmmu); + } + + mutex_unlock(&owner->rpm_lock); + + list_for_each_entry(data, &owner->controllers, owner_node) { pm_runtime_get_sync(data->sysmmu); - __sysmmu_enable(data); } dev_dbg(dev, "%s: Attached IOMMU with pgtable %pa\n", __func__, @@ -1200,6 +1226,7 @@ static int exynos_iommu_of_xlate(struct device *dev, return -ENOMEM; INIT_LIST_HEAD(&owner->controllers); + mutex_init(&owner->rpm_lock); dev->archdata.iommu = owner; } -- 1.9.1