From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933396AbcJTHXy (ORCPT ); Thu, 20 Oct 2016 03:23:54 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:20695 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754784AbcJTHXl (ORCPT ); Thu, 20 Oct 2016 03:23:41 -0400 X-AuditID: cbfec7f4-f791c6d000006eac-d5-580870f8b966 From: Marek Szyprowski To: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski , Joerg Roedel , Inki Dae , Kukjin Kim , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , "Rafael J. Wysocki" , Mark Brown , "Luis R. Rodriguez" , Greg Kroah-Hartman , Tomeu Vizoso , Lukas Wunner , Kevin Hilman , Tobias Jakobi , Tomasz Figa Subject: [PATCH v5 7/7] iommu/exynos: Use device dependency links to control runtime pm Date: Thu, 20 Oct 2016 09:22:53 +0200 Message-id: <1476948173-21093-8-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1476948173-21093-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAAzWSW0gUcRTG+8/Mzoyrk9NqdfIWLPjSxTIE/2mZhdEEPgglai+51aTSrsqO VoqQl/KysSpKKKklaVmmmZuYmmRrsiKra16SIOziuiml4S1KCsl16u33nfPxnXPgsKTqrsKL TUpOE/XJGq2aVlLtllXb3l+pbOz+7vcHcWtliwLf+jxN47y6FhqXfSylcG1PKC6qesrgEvs3 Ejue2Qk8PLwux7qqabxs7EO4cvglgWdnvHFz3ySD35U6EB60jipw/uMFBW7s+oNwcfMoHe4h TJvvEELHZD0SOm9PMoKpsYgWemqaGKH8XQMS1iyM0Pa2gBKK2xqRsGzyEyoL2hVRrmeUhy6I 2qTLon5fWLwyseCLlUjtcr9qtC4x2WjRzYBYFvggqJgJNCCXddwGbz600AakZFX8fQTGQSMj i2UEDdZcUnYFwdDcOO1kFf8AQfVElmzKJuBl0TjlbNB8IBjmDRtRnnwOgpXCesIpSH6Kgvyc e8jp8uDjwNR1nXAyxftDb8nDjViOF6Bg4gMtj/ODAUu5wsku/El40WQknUHAzzOw9LyfkI/w BdOrf+tFwM+bRkJmD/ja38bI7ANFheZ/9RIEuTd2y1yJwDbPyRwKr/tHNmaR/GYoa68g5XgO CvNVMgow2Ropu49ClW2Cko+vRmBfLGdKkU8t2tSIPMV0SZcgSkEBkkYnpScnBJxP0ZnQ+ttY 1/pXOlCdJaQX8SxSu3GJNiZWpdBcljJ0vQhYUu3JnTvPxqq4C5qMTFGfclafrhWlXuTNUurt XHfteIyKT9CkiZdEMVXU/+8SrItXNopPVibOgJQ39T3yWHtohsvQj7QDQdHfGLZHOzC2Mzvs k2+h44Sv/WI3EJ2WPaYULybgVfRHn9+PFnQjO0ZcY8Sdjr0RtafQBF2zJYuyBaPVqCvR1xxx T+Ib6EyOM+/ocJ+da2p76L9n8XOwdnarPW/1SPDKaog5vPP44dNUgpqSEjWBu0i9pPkLRHGC uTIDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEIsWRmVeSWpSXmKPExsVy+t/xK7rPCzgiDM6ssbbYOGM9q8XUh0/Y LJoXr2ezmHR/AovFgv3WFp2zN7Bb9D9+zWzxdPNjJovz54Hcy7vmsFl87j3CaDHj/D4mixfP pS3WHrnLbnFjwlNGizOnL7FatK3+wGqxatcfRou+tZfYHIQ9nhycx+Sx4+4SRo+ds+6ye2xa 1cnmsX/uGnaPyTeWM3r8O8buseVqO4tH35ZVjB6fN8l5zGjfxhrAHeVmk5GamJJapJCal5yf kpmXbqsUGuKma6GkkJeYm2qrFKHrGxKkpFCWmFMK5BkZoAEH5wD3YCV9uwS3jPZnp5kKdvFX 9J7+xN7A+JGni5GTQ0LAROLsmytsELaYxIV764FsLg4hgSWMEufXfYJympgk/n+fywpSxSZg KNH1tgssISLQyCixbetEdhCHWeAZi8SCH9vAZgkLREps2tXCBGKzCKhKHOpfARbnFfCQaL92 D2qfnMTJY5PBpnIKeErsXtPLDGILAdW837iOcQIj7wJGhlWMIqmlxbnpucWGesWJucWleel6 yfm5mxiB8bft2M/NOxgvbQw+xCjAwajEw5txjj1CiDWxrLgy9xCjBAezkgjvsRyOCCHelMTK qtSi/Pii0pzU4kOMpkBHTWSWEk3OB6aGvJJ4QxNDc0tDI2MLC3MjIyVx3pIPV8KFBNITS1Kz U1MLUotg+pg4OKUaGLsPRduanZ5UlOfuUXrkeMC3Vx/37vKxsLaYvDR/nXznnld+s7PcjISK 3xtLyjIle3Z+DZKsWvIgVcpARdrdzOuMed3scwe28E/N0vC/aBGy582yaY+ki9JWPmece2uO a/JMTmbbw67Sa8IfrX3vHjOzqPTha2Uzm9W523snGeZ77ehK6LeOV2Ipzkg01GIuKk4EAPR7 oJfVAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161020072336eucas1p24a2b020f69b6ae1f55e1760e6e0e94f9 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161020072336eucas1p24a2b020f69b6ae1f55e1760e6e0e94f9 X-RootMTR: 20161020072336eucas1p24a2b020f69b6ae1f55e1760e6e0e94f9 References: <1476948173-21093-1-git-send-email-m.szyprowski@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch uses recently introduced device dependency links to track the runtime pm state of the master's device. This way each SYSMMU controller is set to runtime active only when its master's device is active and can restore or save its state instead of being activated all the time when attached to the given master device. This way SYSMMU controllers no longer prevents respective power domains to be turned off when master's device is not being used. Signed-off-by: Marek Szyprowski --- drivers/iommu/exynos-iommu.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 5e6d7bbf9b70..59b4f2ce4f5f 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -781,10 +781,6 @@ static void exynos_iommu_detach_device(struct iommu_domain *iommu_domain, if (!has_sysmmu(dev) || owner->domain != iommu_domain) return; - list_for_each_entry(data, &owner->controllers, owner_node) { - pm_runtime_put_sync(data->sysmmu); - } - mutex_lock(&owner->rpm_lock); list_for_each_entry(data, &owner->controllers, owner_node) { @@ -848,10 +844,6 @@ static int exynos_iommu_attach_device(struct iommu_domain *iommu_domain, mutex_unlock(&owner->rpm_lock); - list_for_each_entry(data, &owner->controllers, owner_node) { - pm_runtime_get_sync(data->sysmmu); - } - dev_dbg(dev, "%s: Attached IOMMU with pgtable %pa\n", __func__, &pagetable); @@ -1232,6 +1224,14 @@ static int exynos_iommu_of_xlate(struct device *dev, list_add_tail(&data->owner_node, &owner->controllers); data->master = dev; + + /* + * SYSMMU will be runtime activated via device link (dependency) to its + * master device, so there are no direct calls to pm_runtime_get/put + * in this driver. + */ + device_link_add(dev, data->sysmmu, DL_FLAG_PM_RUNTIME); + return 0; } -- 1.9.1