From: Joel Fernandes <joelaf@google.com>
To: linux-kernel@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>,
Joel Fernandes <joelaf@google.com>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: [PATCH v2 3/7] pstore: Warn for the case of PSTORE_TYPE_PMSG write using deprecated function
Date: Thu, 20 Oct 2016 00:34:02 -0700 [thread overview]
Message-ID: <1476948846-15006-4-git-send-email-joelaf@google.com> (raw)
In-Reply-To: <1476948846-15006-1-git-send-email-joelaf@google.com>
PMSG now uses ramoops_pstore_write_buf_user instead of ramoops_pstore_write_buf
Print a ratelimited warning if the ramoops_pstore_write_buf is called.
Signed-off-by: Joel Fernandes <joelaf@google.com>
---
fs/pstore/ram.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index cb07ef6..9104ae9 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -288,10 +288,8 @@ static int notrace ramoops_pstore_write_buf(enum pstore_type_id type,
persistent_ram_write(cxt->fprz, buf, size, PSTORE_RAM_LOCK);
return 0;
} else if (type == PSTORE_TYPE_PMSG) {
- if (!cxt->mprz)
- return -ENOMEM;
- persistent_ram_write(cxt->mprz, buf, size, PSTORE_RAM_LOCK);
- return 0;
+ pr_warn_ratelimited("ramoops: warning: PMSG shouldn't call %s\n",
+ __func__);
}
if (type != PSTORE_TYPE_DMESG)
--
2.7.4
next prev parent reply other threads:[~2016-10-20 7:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 7:33 [PATCH v2 0/7] pstore: Improve performance of ftrace backend with ramoops Joel Fernandes
2016-10-20 7:34 ` [PATCH v2 1/7] pstore: Make spinlock per zone instead of global Joel Fernandes
2016-11-11 0:06 ` Kees Cook
2016-11-11 0:24 ` Joel Fernandes
2016-10-20 7:34 ` [PATCH v2 2/7] pstore: locking: dont lock unless caller asks to Joel Fernandes
2016-11-11 0:10 ` Kees Cook
2016-11-11 18:16 ` Kees Cook
2016-10-20 7:34 ` Joel Fernandes [this message]
2016-11-11 0:10 ` [PATCH v2 3/7] pstore: Warn for the case of PSTORE_TYPE_PMSG write using deprecated function Kees Cook
2016-10-20 7:34 ` [PATCH v2 4/7] pstore: Make ramoops_init_przs generic for other prz arrays Joel Fernandes
2016-11-11 0:12 ` Kees Cook
2016-10-20 7:34 ` [PATCH v2 5/7] ramoops: Split ftrace buffer space into per-CPU zones Joel Fernandes
2016-11-11 0:13 ` Kees Cook
2016-11-11 0:16 ` Joel Fernandes
2016-11-11 18:27 ` Kees Cook
2016-10-20 7:34 ` [PATCH v2 6/7] pstore: Add support to store timestamp counter in ftrace records Joel Fernandes
2016-11-11 0:15 ` Kees Cook
2016-11-11 0:21 ` Joel Fernandes
2016-11-11 18:29 ` Kees Cook
2016-10-20 7:34 ` [PATCH v2 7/7] pstore: Merge per-CPU ftrace zones into one zone for output Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476948846-15006-4-git-send-email-joelaf@google.com \
--to=joelaf@google.com \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).