From: Nick Dyer <nick@shmanahar.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andrew Duggan <aduggan@synaptics.com>
Cc: Chris Healy <cphealy@gmail.com>,
Henrik Rydberg <rydberg@bitmath.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Nick Dyer <nick@shmanahar.org>
Subject: [PATCH v5 2/7] Input: synaptics-rmi4 - add a couple of debug lines
Date: Mon, 24 Oct 2016 22:51:52 +0100 [thread overview]
Message-ID: <1477345917-25326-3-git-send-email-nick@shmanahar.org> (raw)
In-Reply-To: <1477345917-25326-1-git-send-email-nick@shmanahar.org>
Signed-off-by: Nick Dyer <nick@shmanahar.org>
---
drivers/input/rmi4/rmi_bus.c | 3 +++
drivers/input/rmi4/rmi_driver.c | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c
index ef8c747..3c6a1b5 100644
--- a/drivers/input/rmi4/rmi_bus.c
+++ b/drivers/input/rmi4/rmi_bus.c
@@ -230,6 +230,9 @@ int rmi_register_function(struct rmi_function *fn)
void rmi_unregister_function(struct rmi_function *fn)
{
+ rmi_dbg(RMI_DEBUG_CORE, &fn->dev, "Unregistering F%02X.\n",
+ fn->fd.function_number);
+
device_del(&fn->dev);
of_node_put(fn->dev.of_node);
put_device(&fn->dev);
diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
index 63c9e22..adb3ee8 100644
--- a/drivers/input/rmi4/rmi_driver.c
+++ b/drivers/input/rmi4/rmi_driver.c
@@ -722,6 +722,7 @@ static int rmi_initial_reset(struct rmi_device *rmi_dev,
return RMI_SCAN_DONE;
}
+ rmi_dbg(RMI_DEBUG_CORE, &rmi_dev->dev, "Sending reset\n");
error = rmi_write_block(rmi_dev, cmd_addr, &cmd_buf, 1);
if (error) {
dev_err(&rmi_dev->dev,
--
2.7.4
next prev parent reply other threads:[~2016-10-24 21:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 21:51 [PATCH v5 0/7] Input: synaptics-rmi4 - F34 device reflash support Nick Dyer
2016-10-24 21:51 ` [PATCH v5 1/7] Input: synaptics-rmi4 - factor out functions from probe Nick Dyer
2016-11-08 1:48 ` Dmitry Torokhov
2016-10-24 21:51 ` Nick Dyer [this message]
2016-11-08 1:49 ` [PATCH v5 2/7] Input: synaptics-rmi4 - add a couple of debug lines Dmitry Torokhov
2016-10-24 21:51 ` [PATCH v5 3/7] Input: synaptics-rmi4 - add support for F34 device reflash Nick Dyer
2016-11-08 1:47 ` Dmitry Torokhov
2016-10-24 21:51 ` [PATCH v5 4/7] Input: synaptics-rmi4 - add support for F34 V7 bootloader Nick Dyer
2016-10-24 21:51 ` [PATCH v5 5/7] Input: synaptics-rmi4 - add sysfs attribute update_fw_status Nick Dyer
2016-10-24 21:51 ` [PATCH v5 6/7] Input: synaptics-rmi4 - add sysfs interfaces for hardware IDs Nick Dyer
2016-10-24 21:51 ` [PATCH v5 7/7] Input: synaptics-rmi4 - add package_id sysfs attribute Nick Dyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477345917-25326-3-git-send-email-nick@shmanahar.org \
--to=nick@shmanahar.org \
--cc=aduggan@synaptics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bjorn.andersson@linaro.org \
--cc=cphealy@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).