From: Eric Dumazet <eric.dumazet@gmail.com>
To: Abdelrhman Ahmed <ab@abahmed.com>
Cc: davem <davem@davemloft.net>, netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: Reset skb to network header in neigh_hh_output
Date: Wed, 26 Oct 2016 10:08:31 -0700 [thread overview]
Message-ID: <1477501711.7065.198.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <15801e95765.f826e84d266359.4807464957002677781@abahmed.com>
On Wed, 2016-10-26 at 18:53 +0200, Abdelrhman Ahmed wrote:
> I think it's at the right place as the current one is a little different from the
> commit e1f165032c8bade3a6bdf546f8faf61fda4dd01c.
>
> In the next lines, skb_push is called after copying the hardware header and there
> is no change to the data pointer inside the retry loop. We only need to reset
> before this loop.
>
> __skb_pull(skb, skb_network_offset(skb));
>
> do {
> seq = read_seqbegin(&hh->hh_lock);
> hh_len = hh->hh_len;
> if (likely(hh_len <= HH_DATA_MOD)) {
> /* this is inlined by gcc */
> memcpy(skb->data - HH_DATA_MOD, hh->hh_data, HH_DATA_MOD);
> } else {
> int hh_alen = HH_DATA_ALIGN(hh_len);
>
> memcpy(skb->data - hh_alen, hh->hh_data, hh_alen);
> }
> } while (read_seqretry(&hh->hh_lock, seq));
>
> skb_push(skb, hh_len);
>
> In the commit e1f165032c8bade3a6bdf546f8faf61fda4dd01c, dev_hard_header which
> calls create method for adding hardware header (uses skb_push) so it was
> required to reset to network header in the beginning of the retry loop.
Right you are, thanks for the clarification !
Back to the cause of the bug then.
If netfilter is the only case this might be needed, can't this be fixed
in netfilter ?
neigh_hh_output() is in fast path, it is quite annoying adding this
operation.
prev parent reply other threads:[~2016-10-26 17:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 14:14 [PATCH] net: Reset skb to network header in neigh_hh_output Abdelrhman Ahmed
2016-10-07 16:27 ` Sergei Shtylyov
2016-10-07 16:38 ` Sergei Shtylyov
2016-10-07 21:10 ` Eric Dumazet
2016-10-25 23:57 ` Abdelrhman Ahmed
2016-10-26 0:12 ` Eric Dumazet
2016-10-26 16:53 ` Abdelrhman Ahmed
2016-10-26 17:08 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477501711.7065.198.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=ab@abahmed.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).