From: Aaron Tomlin <atomlin@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: rusty@rustcorp.com.au, rostedt@goodmis.org
Subject: [RFC PATCH v2 2/2] module: When modifying a module's text ignore modules which are going away too
Date: Thu, 27 Oct 2016 10:36:06 +0100 [thread overview]
Message-ID: <1477560966-781-1-git-send-email-atomlin@redhat.com> (raw)
In-Reply-To: <20161026080914.5bc68d0d@gandalf.local.home>
By default, during the access permission modification of a module's core
and init pages, we only ignore modules that are malformed. Albeit for a
module which is going away, it does not make sense to change its text to
RO since the module should be RW, before deallocation.
This patch makes set_all_modules_text_ro() skip modules which are going
away too.
Signed-off-by: Aaron Tomlin <atomlin@redhat.com>
---
kernel/module.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/module.c b/kernel/module.c
index ff93ab8..2a383df 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1969,7 +1969,8 @@ void set_all_modules_text_ro(void)
mutex_lock(&module_mutex);
list_for_each_entry_rcu(mod, &modules, list) {
- if (mod->state == MODULE_STATE_UNFORMED)
+ if (mod->state == MODULE_STATE_UNFORMED ||
+ mod->state == MODULE_STATE_GOING)
continue;
frob_text(&mod->core_layout, set_memory_ro);
--
2.5.5
next prev parent reply other threads:[~2016-10-27 13:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 16:18 [RFC PATCH 0/2] Possible race between load_module() error handling and kprobe registration ? Aaron Tomlin
2016-10-20 16:18 ` [RFC PATCH 1/2] module: Ensure a module's state is set accordingly during module coming cleanup code Aaron Tomlin
2016-10-26 0:54 ` Rusty Russell
2016-11-09 10:12 ` Jessica Yu
2016-11-16 15:49 ` Miroslav Benes
2016-11-23 23:41 ` Jessica Yu
2016-10-20 16:18 ` [RFC PATCH 2/2] module: When modifying a module's text ignore modules which are going away too Aaron Tomlin
2016-10-26 1:05 ` Rusty Russell
2016-10-26 12:09 ` Steven Rostedt
2016-10-27 9:36 ` Aaron Tomlin [this message]
2016-10-27 13:49 ` [RFC PATCH v2 " Steven Rostedt
2016-11-07 11:46 ` Aaron Tomlin
2016-11-09 10:40 ` Jessica Yu
2016-11-23 16:00 ` Steven Rostedt
2016-11-23 18:33 ` Jessica Yu
2016-11-18 6:15 ` [RFC PATCH v2 2/2] " Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477560966-781-1-git-send-email-atomlin@redhat.com \
--to=atomlin@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).