From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Wang Nan <wangnan0@huawei.com>, Nambong Ha <over3025@gmail.com>,
Wookje Kwon <aweee0@gmail.com>,
Taeung Song <treeze.taeung@gmail.com>
Subject: [PATCH 3/6] perf config: Parse config variable arguments before getting functionality
Date: Fri, 4 Nov 2016 15:44:19 +0900 [thread overview]
Message-ID: <1478241862-31230-4-git-send-email-treeze.taeung@gmail.com> (raw)
In-Reply-To: <1478241862-31230-1-git-send-email-treeze.taeung@gmail.com>
You can get several config items as below,
# perf config report.queue-size call-graph.record-mode
but it would be needed to more precisely check arguments,
before show_spec_config() takes over the arguments.
The function would be also used when parse config key-value pairs
arguments in the near future.
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
tools/perf/builtin-config.c | 45 +++++++++++++++++++++++++++++++++++++++++----
1 file changed, 41 insertions(+), 4 deletions(-)
diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c
index df3fa1c..fe253f3 100644
--- a/tools/perf/builtin-config.c
+++ b/tools/perf/builtin-config.c
@@ -82,6 +82,27 @@ static int show_config(struct perf_config_set *set)
return 0;
}
+static int parse_config_arg(char *arg, char **var)
+{
+ const char *last_dot = strchr(arg, '.');
+
+ /*
+ * Since "var" actually contains the section name and the real
+ * config variable name separated by a dot, we have to know where the dot is.
+ */
+ if (last_dot == NULL || last_dot == arg) {
+ pr_err("The config variable does not contain a section: %s\n", arg);
+ return -1;
+ }
+ if (!last_dot[1]) {
+ pr_err("The config varible does not contain variable name: %s\n", arg);
+ return -1;
+ }
+
+ *var = arg;
+ return 0;
+}
+
int cmd_config(int argc, const char **argv, const char *prefix __maybe_unused)
{
int i, ret = 0;
@@ -130,10 +151,26 @@ int cmd_config(int argc, const char **argv, const char *prefix __maybe_unused)
}
break;
default:
- if (argc)
- for (i = 0; argv[i]; i++)
- ret = show_spec_config(set, argv[i]);
- else
+ if (argc) {
+ for (i = 0; argv[i]; i++) {
+ char *var, *arg = strdup(argv[i]);
+
+ if (!arg) {
+ pr_err("%s: strdup failed\n", __func__);
+ ret = -1;
+ break;
+ }
+
+ if (parse_config_arg(arg, &var) < 0) {
+ free(arg);
+ ret = -1;
+ break;
+ }
+
+ ret = show_spec_config(set, var);
+ free(arg);
+ }
+ } else
usage_with_options(config_usage, config_options);
}
--
2.7.4
next prev parent reply other threads:[~2016-11-04 6:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 6:44 [PATCH 0/6] perf config: Add support for setting and getting functionalities Taeung Song
2016-11-04 6:44 ` [PATCH 1/6] perf config: Add support for getting config key-value pairs Taeung Song
2016-11-14 15:50 ` Arnaldo Carvalho de Melo
2016-11-14 16:21 ` Taeung Song
2016-11-28 9:02 ` Taeung Song
2016-11-15 10:44 ` [tip:perf/core] " tip-bot for Taeung Song
2016-11-04 6:44 ` [PATCH 2/6] perf config: Document examples to get config key-value pairs in man page Taeung Song
2016-11-14 15:51 ` Arnaldo Carvalho de Melo
2016-11-14 16:30 ` Taeung Song
2016-11-04 6:44 ` Taeung Song [this message]
2016-11-15 10:44 ` [tip:perf/core] perf config: Validate config variable arguments before trying use them tip-bot for Taeung Song
2016-11-04 6:44 ` [PATCH 4/6] perf config: Add support for writing configs to a config file Taeung Song
2016-11-14 16:04 ` Arnaldo Carvalho de Melo
2016-11-14 17:00 ` Taeung Song
2016-11-15 1:49 ` Arnaldo Carvalho de Melo
2016-11-15 2:28 ` Taeung Song
2016-11-15 10:45 ` [tip:perf/core] perf config: Add support setting variables in " tip-bot for Taeung Song
2016-11-04 6:44 ` [PATCH 5/6] perf config: Document examples to set config variables with values in man page Taeung Song
2016-11-04 6:44 ` [PATCH 6/6] perf config: Mark where are config items from (user or system) Taeung Song
2016-11-15 10:46 ` [tip:perf/core] " tip-bot for Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478241862-31230-4-git-send-email-treeze.taeung@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=acme@kernel.org \
--cc=aweee0@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=over3025@gmail.com \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).