From: John Garry <john.garry@huawei.com>
To: <martin.petersen@oracle.com>, <jejb@linux.vnet.ibm.com>
Cc: <linux-scsi@vger.kernel.org>, <linuxarm@huawei.com>,
<linux-kernel@vger.kernel.org>, <john.garry2@mail.dcu.ie>,
Xiang Chen <chenxiang66@hisilicon.com>,
John Garry <john.garry@huawei.com>
Subject: [PATCH 06/11] hisi_sas: modify return value of hisi_sas_query_task()
Date: Mon, 7 Nov 2016 20:48:35 +0800 [thread overview]
Message-ID: <1478522920-108145-7-git-send-email-john.garry@huawei.com> (raw)
In-Reply-To: <1478522920-108145-1-git-send-email-john.garry@huawei.com>
From: Xiang Chen <chenxiang66@hisilicon.com>
sas_scsi_find_task() only deals with return value
TMF_RESP_FUNC_FAILED/TMF_RESP_FUNC_SUCC/TMF_RESP_FUNC_COMPLETE of
query task. So for LLDD errors just return TMF_RESP_FUNC_FAILED.
Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: John Garry <john.garry@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 9133238..504cbcf 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -961,6 +961,9 @@ static int hisi_sas_query_task(struct sas_task *task)
case TMF_RESP_FUNC_FAILED:
case TMF_RESP_FUNC_COMPLETE:
break;
+ default:
+ rc = TMF_RESP_FUNC_FAILED;
+ break;
}
}
return rc;
--
1.9.1
next prev parent reply other threads:[~2016-11-07 12:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 12:48 [PATCH 00/11] hisi_sas: some fixes, improvements, and new features John Garry
2016-11-07 12:48 ` [PATCH 01/11] hisi_sas: add v2 hw support for ECC and AXI bus fatal error John Garry
2016-11-16 1:47 ` Zhangfei Gao
2016-11-23 8:59 ` John Garry
2016-11-23 9:13 ` Zhangfei Gao
2016-11-07 12:48 ` [PATCH 02/11] hisi_sas: alloc queue id of slot according to device id John Garry
2016-11-16 1:41 ` Zhangfei Gao
2016-11-16 10:02 ` John Garry
2016-11-07 12:48 ` [PATCH 03/11] hisi_sas: only process broadcast change in phy_bcast_v2_hw() John Garry
2016-11-16 1:47 ` Zhangfei Gao
2016-11-07 12:48 ` [PATCH 04/11] hisi_sas: fix port form bug in hisi_sas_port_notify_formed() John Garry
2016-11-16 1:43 ` Zhangfei Gao
2016-11-07 12:48 ` [PATCH 05/11] hisi_sas: replace WARN_ON() with dev_warn() for internal abort John Garry
2016-11-23 8:57 ` Zhangfei Gao
2016-11-07 12:48 ` John Garry [this message]
2016-11-16 1:50 ` [PATCH 06/11] hisi_sas: modify return value of hisi_sas_query_task() Zhangfei Gao
2016-11-07 12:48 ` [PATCH 07/11] hisi_sas: delete repeated configuration in free_device_v2_hw() John Garry
2016-11-16 1:43 ` Zhangfei Gao
2016-11-07 12:48 ` [PATCH 08/11] hisi_sas: modify some values in get_ata_protocol() John Garry
2016-11-16 1:44 ` Zhangfei Gao
2016-11-07 12:48 ` [PATCH 09/11] hisi_sas: check SATA FIS when directly attaching SATA device John Garry
2016-11-16 1:49 ` Zhangfei Gao
2016-11-07 12:48 ` [PATCH 10/11] hisi_sas: use atomic64_t for hisi_sas_device.running_req John Garry
2016-11-16 1:44 ` Zhangfei Gao
2016-11-07 12:48 ` [PATCH 11/11] hisi_sas: add PHY set linkrate support for v1 and v2 hw John Garry
2016-11-16 1:48 ` Zhangfei Gao
2016-11-14 23:49 ` [PATCH 00/11] hisi_sas: some fixes, improvements, and new features Martin K. Petersen
2016-11-22 16:41 ` John Garry
2016-11-22 22:01 ` Martin K. Petersen
2016-11-25 11:40 ` John Garry
2016-11-25 14:55 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478522920-108145-7-git-send-email-john.garry@huawei.com \
--to=john.garry@huawei.com \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry2@mail.dcu.ie \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).