From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932782AbcKGQyT (ORCPT ); Mon, 7 Nov 2016 11:54:19 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34278 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932685AbcKGQyO (ORCPT ); Mon, 7 Nov 2016 11:54:14 -0500 From: Andrey Smirnov To: linux-gpio@vger.kernel.org Cc: Andrey Smirnov , linus.walleij@linaro.org, narmstrong@baylibre.com, linux-kernel@vger.kernel.org, cphealy@gmail.com Subject: [PATCH v2 15/15] pinctrl-sx150x: Remove magic numbers from sx150x_reset Date: Mon, 7 Nov 2016 08:53:23 -0800 Message-Id: <1478537603-23653-16-git-send-email-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1478537603-23653-1-git-send-email-andrew.smirnov@gmail.com> References: <1478537603-23653-1-git-send-email-andrew.smirnov@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tested-by: Neil Armstrong Acked-by: Neil Armstrong Signed-off-by: Andrey Smirnov --- drivers/pinctrl/pinctrl-sx150x.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx150x.c index 56abe36..dc1341f 100644 --- a/drivers/pinctrl/pinctrl-sx150x.c +++ b/drivers/pinctrl/pinctrl-sx150x.c @@ -49,6 +49,8 @@ enum { SX150X_MAX_REGISTER = 0xad, SX150X_IRQ_TYPE_EDGE_RISING = 0x1, SX150X_IRQ_TYPE_EDGE_FALLING = 0x2, + SX150X_789_RESET_KEY1 = 0x12, + SX150X_789_RESET_KEY2 = 0x34, }; struct sx150x_123_pri { @@ -771,13 +773,13 @@ static int sx150x_reset(struct sx150x_pinctrl *pctl) err = i2c_smbus_write_byte_data(pctl->client, pctl->data->pri.x789.reg_reset, - 0x12); + SX150X_789_RESET_KEY1); if (err < 0) return err; err = i2c_smbus_write_byte_data(pctl->client, pctl->data->pri.x789.reg_reset, - 0x34); + SX150X_789_RESET_KEY2); return err; } -- 2.5.5