From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932917AbcKGQ5L (ORCPT ); Mon, 7 Nov 2016 11:57:11 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34243 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932367AbcKGQyG (ORCPT ); Mon, 7 Nov 2016 11:54:06 -0500 From: Andrey Smirnov To: linux-gpio@vger.kernel.org Cc: Andrey Smirnov , linus.walleij@linaro.org, narmstrong@baylibre.com, linux-kernel@vger.kernel.org, cphealy@gmail.com Subject: [PATCH v2 05/15] pinctrl-sx150x: Fix incorrect constant in sx150x_init_hw Date: Mon, 7 Nov 2016 08:53:13 -0800 Message-Id: <1478537603-23653-6-git-send-email-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1478537603-23653-1-git-send-email-andrew.smirnov@gmail.com> References: <1478537603-23653-1-git-send-email-andrew.smirnov@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According to the datasheet for SX1504/5/6, RegAdvanced's "Autoclear NINT" bit that turns the feature when set and disables it when cleared, so writing 0x04 to the register will have the opposite from desirable effect. Tested-by: Neil Armstrong Acked-by: Neil Armstrong Signed-off-by: Andrey Smirnov --- drivers/pinctrl/pinctrl-sx150x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx150x.c index 3ccd048..0e3e1da 100644 --- a/drivers/pinctrl/pinctrl-sx150x.c +++ b/drivers/pinctrl/pinctrl-sx150x.c @@ -942,7 +942,7 @@ static int sx150x_init_hw(struct sx150x_pinctrl *pctl) else if (pctl->data->model == SX150X_456) err = sx150x_i2c_write(pctl->client, pctl->data->pri.x456.reg_advance, - 0x04); + 0x00); else err = sx150x_i2c_write(pctl->client, pctl->data->pri.x123.reg_advance, -- 2.5.5