From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933526AbcKGS62 (ORCPT ); Mon, 7 Nov 2016 13:58:28 -0500 Received: from smtprelay0004.hostedemail.com ([216.40.44.4]:51966 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932830AbcKGS6Y (ORCPT ); Mon, 7 Nov 2016 13:58:24 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:69:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3872:4321:5007:10004:10400:10848:11026:11232:11473:11658:11914:12043:12555:12683:12740:13069:13255:13311:13357:13439:13894:14110:14181:14659:21080:21451:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: test09_8eb08716805f X-Filterd-Recvd-Size: 1824 Message-ID: <1478545060.22008.5.camel@perches.com> Subject: Re: [PATCH 01/11] staging: wlan-ng: fix line style issue in macro WLAN_GET_FC_FSTYPE From: Joe Perches To: Sergio Paracuellos , gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 07 Nov 2016 10:57:40 -0800 In-Reply-To: <1478541328-2214-2-git-send-email-sergio.paracuellos@gmail.com> References: <1478541328-2214-1-git-send-email-sergio.paracuellos@gmail.com> <1478541328-2214-2-git-send-email-sergio.paracuellos@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-11-07 at 18:55 +0100, Sergio Paracuellos wrote: > This patch fix the following checkpatch.pl script warning: > WARNING: line over 80 characters > > It also add spaces between or operators inside the macro to > comply with the standard kernel coding style. [] > diff --git a/drivers/staging/wlan-ng/p80211hdr.h b/drivers/staging/wlan-ng/p80211hdr.h [] > @@ -132,7 +132,8 @@ > /*------------------------------------------------------------*/ > > #define WLAN_GET_FC_FTYPE(n) ((((u16)(n)) & (BIT(2) | BIT(3))) >> 2) > -#define WLAN_GET_FC_FSTYPE(n) ((((u16)(n)) & (BIT(4)|BIT(5)|BIT(6)|BIT(7))) >> 4) > +#define WLAN_GET_FC_FSTYPE(n) ((((u16)(n)) & \ > + (BIT(4) | BIT(5) | BIT(6) | BIT(7))) >> 4) Probably better to use GENMASK #define WLAN_GET_FC_FTYPE(n) ((((u16)(n)) & GENMASK(3, 2)) >> 2)  #define WLAN_GET_FC_FSTYPE(n) ((((u16)(n)) & GENMASK(7, 4)) >> 4)