From: Ravikant Bijendra Sharma <ravikant.s2@samsung.com>
To: Russell King <rmk+kernel@armlinux.org.uk>,
David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org,
Ravikant Bijendra Sharma <ravikant.s2@samsung.com>,
shailesh pandey <p.shailesh@samsung.com>,
vidushi.koul@samsung.com, linux-kernel@vger.kernel.org
Subject: [PATCH] drm/armada: Fix NULL pointer comparison warning
Date: Tue, 08 Nov 2016 11:30:09 +0530 [thread overview]
Message-ID: <1478584809-4423-1-git-send-email-ravikant.s2@samsung.com> (raw)
From: Ravikant B Sharma <ravikant.s2@samsung.com>
Replace direct comparisons to NULL i.e.
'x == NULL' with '!x'. As per coding standard.
Signed-off-by: Ravikant B Sharma <ravikant.s2@samsung.com>
---
drivers/gpu/drm/armada/armada_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/armada/armada_debugfs.c b/drivers/gpu/drm/armada/armada_debugfs.c
index d4f7ab0..90222e6 100644
--- a/drivers/gpu/drm/armada/armada_debugfs.c
+++ b/drivers/gpu/drm/armada/armada_debugfs.c
@@ -113,7 +113,7 @@ static int drm_add_fake_info_node(struct drm_minor *minor, struct dentry *ent,
struct drm_info_node *node;
node = kmalloc(sizeof(struct drm_info_node), GFP_KERNEL);
- if (node == NULL) {
+ if (!node) {
debugfs_remove(ent);
return -ENOMEM;
}
--
1.7.9.5
reply other threads:[~2016-11-08 6:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478584809-4423-1-git-send-email-ravikant.s2@samsung.com \
--to=ravikant.s2@samsung.com \
--cc=airlied@linux.ie \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=p.shailesh@samsung.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vidushi.koul@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).