From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: gregkh@linuxfoundation.org
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 7/8] coresight: tmc: Remove duplicate memset
Date: Thu, 10 Nov 2016 11:18:53 -0700 [thread overview]
Message-ID: <1478801934-26904-8-git-send-email-mathieu.poirier@linaro.org> (raw)
In-Reply-To: <1478801934-26904-1-git-send-email-mathieu.poirier@linaro.org>
From: "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>
The tmc_etr_enable_hw() fills the buffer with 0's before enabling
the hardware. So, we don't need an explicit memset() in
tmc_enable_etr_sink_sysfs() before calling the tmc_etr_enable_hw().
This patch removes the explicit memset from tmc_enable_etr_sink_sysfs.
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
drivers/hwtracing/coresight/coresight-tmc-etr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
index 3b84d0d38c22..5d312699b3b9 100644
--- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
+++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
@@ -150,8 +150,6 @@ static int tmc_enable_etr_sink_sysfs(struct coresight_device *csdev)
drvdata->buf = drvdata->vaddr;
}
- memset(drvdata->vaddr, 0, drvdata->size);
-
drvdata->mode = CS_MODE_SYSFS;
tmc_etr_enable_hw(drvdata);
out:
--
2.7.4
next prev parent reply other threads:[~2016-11-10 18:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 18:18 [PATCH 0/8] coresight: next v4.9-rc4 Mathieu Poirier
2016-11-10 18:18 ` [PATCH 1/8] coresight: stm: return error code instead of zero in .packet() Mathieu Poirier
2016-11-10 18:18 ` [PATCH 2/8] coresight: etm3x: indentation fix (extra space removed) Mathieu Poirier
2016-11-10 18:18 ` [PATCH 3/8] coresight: etm3x: Adding missing features of Coresight PTM components Mathieu Poirier
2016-11-10 18:18 ` [PATCH 4/8] coresight: reset "enable_sink" flag when need be Mathieu Poirier
2016-11-10 18:18 ` [PATCH 5/8] coresight: tmc: Cleanup operation mode handling Mathieu Poirier
2016-11-10 18:18 ` [PATCH 6/8] coresight: tmc: Get rid of mode parameter for helper routines Mathieu Poirier
2016-11-10 18:18 ` Mathieu Poirier [this message]
2016-11-10 18:18 ` [PATCH 8/8] coresight: Add support for ARM Coresight STM-500 Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478801934-26904-8-git-send-email-mathieu.poirier@linaro.org \
--to=mathieu.poirier@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).