From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936606AbcKNScm (ORCPT ); Mon, 14 Nov 2016 13:32:42 -0500 Received: from mail-pf0-f173.google.com ([209.85.192.173]:33654 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934382AbcKNSch (ORCPT ); Mon, 14 Nov 2016 13:32:37 -0500 From: Rob Rice To: Jassi Brar Cc: bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, Steve Lin , Rob Rice Subject: [PATCH 01/11] mailbox: bcm-pdc: Use octal permissions rather than symbolic Date: Mon, 14 Nov 2016 13:25:55 -0500 Message-Id: <1479147965-29662-2-git-send-email-rob.rice@broadcom.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1479147965-29662-1-git-send-email-rob.rice@broadcom.com> References: <1479147965-29662-1-git-send-email-rob.rice@broadcom.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When creating the debugfs files for the PDC driver, use octal file permissions rather than symbolic file permissions. Signed-off-by: Rob Rice Reviewed-by: Andy Gospodarek --- drivers/mailbox/bcm-pdc-mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/bcm-pdc-mailbox.c b/drivers/mailbox/bcm-pdc-mailbox.c index c19dd82..a9c804f 100644 --- a/drivers/mailbox/bcm-pdc-mailbox.c +++ b/drivers/mailbox/bcm-pdc-mailbox.c @@ -480,7 +480,8 @@ static void pdc_setup_debugfs(struct pdc_state *pdcs) if (!debugfs_dir) debugfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL); - pdcs->debugfs_stats = debugfs_create_file(spu_stats_name, S_IRUSR, + /* S_IRUSR == 0400 */ + pdcs->debugfs_stats = debugfs_create_file(spu_stats_name, 0400, debugfs_dir, pdcs, &pdc_debugfs_stats); } -- 2.1.0