From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934211AbcKQFDL (ORCPT ); Thu, 17 Nov 2016 00:03:11 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:10721 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932333AbcKQFDI (ORCPT ); Thu, 17 Nov 2016 00:03:08 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Wed, 16 Nov 2016 09:02:04 -0800 From: Kirti Wankhede To: , , , CC: , , , , , , Kirti Wankhede Subject: Re: [PATCH v14 12/22] vfio: Add notifier callback to parent's ops structure of mdev Date: Thu, 17 Nov 2016 10:34:29 +0530 Message-ID: <1479359069-20452-1-git-send-email-kwankhede@nvidia.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1479329194-10247-13-git-send-email-kwankhede@nvidia.com> References: <1479329194-10247-13-git-send-email-kwankhede@nvidia.com> X-NVConfidentiality: public MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a notifier calback to parent's ops structure of mdev device so that per device notifer for vfio module is registered through vfio_mdev module. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: Iafa6f1721aecdd6e50eb93b153b5621e6d29b637 --- drivers/vfio/mdev/vfio_mdev.c | 32 +++++++++++++++++++++++++++++++- include/linux/mdev.h | 9 +++++++++ 2 files changed, 40 insertions(+), 1 deletion(-) diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c index ffc36758cb84..7ffdc317319d 100644 --- a/drivers/vfio/mdev/vfio_mdev.c +++ b/drivers/vfio/mdev/vfio_mdev.c @@ -24,6 +24,15 @@ #define DRIVER_AUTHOR "NVIDIA Corporation" #define DRIVER_DESC "VFIO based driver for Mediated device" +static int vfio_mdev_notifier(struct notifier_block *nb, unsigned long action, + void *data) +{ + struct mdev_device *mdev = container_of(nb, struct mdev_device, nb); + struct parent_device *parent = mdev->parent; + + return parent->ops->notifier(mdev, action, data); +} + static int vfio_mdev_open(void *device_data) { struct mdev_device *mdev = device_data; @@ -36,9 +45,27 @@ static int vfio_mdev_open(void *device_data) if (!try_module_get(THIS_MODULE)) return -ENODEV; + if (likely(parent->ops->notifier)) { + mdev->nb.notifier_call = vfio_mdev_notifier; + ret = vfio_register_notifier(&mdev->dev, &mdev->nb); + + /* + * This should not fail if backend iommu module doesn't support + * register_notifier. + */ + if (ret && (ret != -ENOTTY)) { + pr_err("Failed to register notifier for mdev\n"); + module_put(THIS_MODULE); + return ret; + } + } + ret = parent->ops->open(mdev); - if (ret) + if (ret) { + if (likely(parent->ops->notifier)) + vfio_unregister_notifier(&mdev->dev, &mdev->nb); module_put(THIS_MODULE); + } return ret; } @@ -51,6 +78,9 @@ static void vfio_mdev_release(void *device_data) if (likely(parent->ops->release)) parent->ops->release(mdev); + if (likely(parent->ops->notifier)) + vfio_unregister_notifier(&mdev->dev, &mdev->nb); + module_put(THIS_MODULE); } diff --git a/include/linux/mdev.h b/include/linux/mdev.h index ec819e9a115a..94c43034c297 100644 --- a/include/linux/mdev.h +++ b/include/linux/mdev.h @@ -37,6 +37,7 @@ struct mdev_device { struct kref ref; struct list_head next; struct kobject *type_kobj; + struct notifier_block nb; }; /** @@ -85,6 +86,12 @@ struct mdev_device { * @mmap: mmap callback * @mdev: mediated device structure * @vma: vma structure + * @notifer: Notifier callback, currently only for + * VFIO_IOMMU_NOTIFY_DMA_UNMAP action notified duing + * DMA_UNMAP call on mapped iova range. + * @mdev: mediated device structure + * @action: Action for which notifier is called + * @data: Data associated with the notifier * Parent device that support mediated device should be registered with mdev * module with parent_ops structure. **/ @@ -106,6 +113,8 @@ struct parent_ops { ssize_t (*ioctl)(struct mdev_device *mdev, unsigned int cmd, unsigned long arg); int (*mmap)(struct mdev_device *mdev, struct vm_area_struct *vma); + int (*notifier)(struct mdev_device *mdev, unsigned long action, + void *data); }; /* interface for exporting mdev supported type attributes */ -- 2.7.0