From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFB93C77B7E for ; Thu, 1 Jun 2023 08:35:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232251AbjFAIfl (ORCPT ); Thu, 1 Jun 2023 04:35:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232348AbjFAIez (ORCPT ); Thu, 1 Jun 2023 04:34:55 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4E4F1712 for ; Thu, 1 Jun 2023 01:33:30 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-96fe2a1db26so66841566b.0 for ; Thu, 01 Jun 2023 01:33:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685608408; x=1688200408; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7BF4PtOkqXGCIjG5sZKC2cc3dbGT96AwN/tCA5yl4J8=; b=H8kqwOz1+oeAMAnwWRIn6XbrBpxt92VOI8IVd92jpNDPNug0aqr0htiUtWi/3Fbg2A vn/NI9DbSGe8OiuS5z6EvO69a2up2iOGx1LKNVYiUVjhN9gwgm32TM0DoGE2HKECOSuZ rdysxreDH55Bb44PVnwumb1vhfEPjFma2V/M86VlsRdbcOKTGovQQ693irZ2zNbvDLuY pIvCq/dWxH+K4ehfTHUx9D1cFLowKiwLpUcg9K0VnaxaHqmTEGe+ioDVwih6M/5D92ju LQSEDgbLN778UPxceff5jHwdr/10ppAGJR+JLpb+sB+RYH11Tf8/AgYmWVUEybZCdyWp e5yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685608408; x=1688200408; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7BF4PtOkqXGCIjG5sZKC2cc3dbGT96AwN/tCA5yl4J8=; b=U8E6qw7cs4vCVLk/juHUbNBCBHl00coBFqIKl+6hbK/RC7GBON7Ot7H9jgdTURflbh oMpktkX1wnHK6Cd4RBoQ728yuKZv7fi5bRIwLtf5nQFOO7RPPied2GBmksUC480MGrvG d9ixl6TAiHnBB8kPcs+QaQq2atI2x+W5gjHSoctyK2GYWhvt+1p+ZBpItXbEeT3nqLZ9 WodJkdnZmJptMDLoMv1YIHEDsEcZSRdIWoR8wscgiyqwgnGckvL1dHWDcT79p3N4GM+c itCMDRJRZPaM9Ks+PM3/PDGn7UkEZ1w4acdqW5GgWyPJJmJaTxSe/Gbp9n1O8xvjFOcD 3pdA== X-Gm-Message-State: AC+VfDxtTNR4XOH7OKGjZ1seEZZql97m30/8IgZuPhzQD0RVpnOYg4M4 VuCSNm2ymOLL35yO8ZMDoTRdmg== X-Google-Smtp-Source: ACHHUZ5W5YuWUPGwqtAYMza3MvhyXmFhj9gL70htopC+b47t/2eJYICooxV4xCv4TdVFXyomVgWfqA== X-Received: by 2002:a17:907:7e8c:b0:96f:c676:a917 with SMTP id qb12-20020a1709077e8c00b0096fc676a917mr8035429ejc.35.1685608408688; Thu, 01 Jun 2023 01:33:28 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id lf4-20020a170907174400b0096f7500502csm10224090ejc.199.2023.06.01.01.33.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 01:33:28 -0700 (PDT) Message-ID: <147fba8a-8c3b-6ed5-22ef-599d9f52ca1d@linaro.org> Date: Thu, 1 Jun 2023 10:33:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 42/43] ARM: dts: ep93xx: Add EDB9302 DT Content-Language: en-US To: Nikita Shubin , Alexander Sverdlin , Arnd Bergmann , Linus Walleij , Rob Herring , Krzysztof Kozlowski Cc: Michael Peters , Kris Bahnsen , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230424123522.18302-1-nikita.shubin@maquefel.me> <20230601054549.10843-24-nikita.shubin@maquefel.me> From: Krzysztof Kozlowski In-Reply-To: <20230601054549.10843-24-nikita.shubin@maquefel.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/2023 07:45, Nikita Shubin wrote: > From: Alexander Sverdlin > > Add device tree for Cirrus EDB9302. > > Signed-off-by: Alexander Sverdlin > Signed-off-by: Nikita Shubin > --- > > Notes: > v0 -> v1: > > - added USB > - dropped 'Missing USB' in commit message > - add mdio + eth phy > > arch/arm/boot/dts/ep93xx-edb9302.dts | 160 +++++++++++++++++++++++++++ > 1 file changed, 160 insertions(+) > create mode 100644 arch/arm/boot/dts/ep93xx-edb9302.dts > > diff --git a/arch/arm/boot/dts/ep93xx-edb9302.dts b/arch/arm/boot/dts/ep93xx-edb9302.dts > new file mode 100644 > index 000000000000..3ec89f7587db > --- /dev/null > +++ b/arch/arm/boot/dts/ep93xx-edb9302.dts > @@ -0,0 +1,160 @@ > +// SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +/* > + * Device Tree file for Cirrus Logic EDB9302 board based on EP9302 SoC > + */ > +/dts-v1/; > +#include "ep93xx.dtsi" > + > +/ { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "cirrus,edb9302", "cirrus,ep9301"; > + model = "cirrus,edb9302"; > + > + chosen { > + }; > + > + memory { > + device_type = "memory"; > + }; > + > + soc { > + flash@60000000 { Same comments - override by label/phandle. > + compatible = "cfi-flash"; > + reg = <0x60000000 0x1000000>; Are you sure that your board adds things to the SoC? The code suggests that, but I would like to see such circuit. > + bank-width = <2>; > + }; > + }; > + > + sound { > + compatible = "simple-audio-card"; > + simple-audio-card,name = "EDB93XX"; > + simple-audio-card,format = "i2s"; > + simple-audio-card,mclk-fs = <256>; > + simple-audio-card,convert-channels = <2>; > + simple-audio-card,convert-sample-format = "s32_le"; > + > + simple-audio-card,cpu { > + sound-dai = <&i2s>; > + system-clock-direction-out; > + frame-master; > + bitclock-master; > + dai-sample-format = "s32_le"; > + dai-channels = <2>; > + }; > + > + simple-audio-card,codec { > + sound-dai = <&codec>; > + }; > + }; > +}; > + > +&pinctrl { > + compatible = "cirrus,ep9301-pinctrl"; > +}; > + > +&gpio0 { > + gpio-ranges = <&pinctrl 0 153 1>, > + <&pinctrl 1 152 1>, > + <&pinctrl 2 151 1>, > + <&pinctrl 3 148 1>, > + <&pinctrl 4 147 1>, > + <&pinctrl 5 146 1>, > + <&pinctrl 6 145 1>, > + <&pinctrl 7 144 1>; > +}; > + > +&gpio1 { > + gpio-ranges = <&pinctrl 0 143 1>, > + <&pinctrl 1 142 1>, > + <&pinctrl 2 141 1>, > + <&pinctrl 3 140 1>, > + <&pinctrl 4 165 1>, > + <&pinctrl 5 164 1>, > + <&pinctrl 6 163 1>, > + <&pinctrl 7 160 1>; > +}; > + > +&gpio2 { > + gpio-ranges = <&pinctrl 0 115 1>; > + /delete-property/ status; ??? > + /delete-property/ pinctrl-0; > + /delete-property/ pinctrl-names; ??? I have no clue what you are trying to achieve here but this is a proof your DTSI is bogus. You should never remove statuses. You should never need to remove pinctrl as these are board dependent, not SoC. If you remove them, it means they are not part of SoC in the first place! Best regards, Krzysztof