From: Oliver Neukum <oneukum@suse.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Badhri Jagan Sridharan <badhri@google.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCHv12 2/3] usb: USB Type-C connector class
Date: Tue, 29 Nov 2016 14:48:46 +0100 [thread overview]
Message-ID: <1480427326.22547.40.camel@suse.com> (raw)
In-Reply-To: <20161129132049.GA1463@kroah.com>
On Tue, 2016-11-29 at 14:20 +0100, Greg KH wrote:
> On Tue, Nov 29, 2016 at 02:59:58PM +0200, Heikki Krogerus wrote:
> > Hi Guenter,
> >
> > On Mon, Nov 28, 2016 at 12:11:43PM -0800, Guenter Roeck wrote:
> > > Personally I don't really care about a module parameter; as mentioned above,
> > > I would expect the preference, if it needs to be selectable, to be configured
> > > with devicetree or ACPI properties (or by a platform driver which sets a device
> > > property).
> >
> > Unfortunately we can not assume the firmware to be always correct.
> > Companies love to recycle the firmware. We are going to see products
> > from a company X that should prefer source role, a desktop for
> > example, but still give the OS a device property that says otherwise.
> > The reason for that is most likely because the previous product from
> > that company was some kind of mobile device.
> >
> > So IMHO we need some way for the OS to override this thing eventually.
> > If not module parameters, then something else. The other option is
> > board specific quirks, and I would really prefer to avoid those if we
> > can.
>
> Whatever it is, it is NOT going to be a module parameter, sorry, that
> ship has long sailed and will not be coming back. This isn't the 1990's
> anymore...
Do you have a sensible alternative that works at boot time?
Regards
Oliver
next prev parent reply other threads:[~2016-11-29 13:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 14:11 [PATCHv12 0/3] USB Type-C Connector class Heikki Krogerus
2016-11-22 14:11 ` [PATCHv12 1/3] lib/string: add sysfs_match_string helper Heikki Krogerus
2016-11-23 16:14 ` Guenter Roeck
2016-11-24 0:17 ` Guenter Roeck
2016-11-22 14:11 ` [PATCHv12 2/3] usb: USB Type-C connector class Heikki Krogerus
2016-11-23 16:27 ` Guenter Roeck
2016-11-24 0:17 ` Guenter Roeck
2016-11-24 5:12 ` Guenter Roeck
2016-11-24 9:57 ` Heikki Krogerus
2016-11-28 10:19 ` Oliver Neukum
2016-11-28 14:23 ` Heikki Krogerus
2016-11-28 20:11 ` Guenter Roeck
2016-11-29 7:40 ` Oliver Neukum
2016-11-29 12:59 ` Heikki Krogerus
2016-11-29 13:20 ` Greg KH
2016-11-29 13:48 ` Oliver Neukum [this message]
2016-11-29 14:02 ` Greg KH
2016-11-22 14:11 ` [PATCHv12 3/3] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Heikki Krogerus
2016-11-23 16:42 ` Guenter Roeck
2016-11-23 14:55 ` [PATCHv12 0/3] USB Type-C Connector class Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480427326.22547.40.camel@suse.com \
--to=oneukum@suse.com \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).