From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754591AbcLCASB (ORCPT ); Fri, 2 Dec 2016 19:18:01 -0500 Received: from mail.windriver.com ([147.11.1.11]:57924 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751657AbcLCAR7 (ORCPT ); Fri, 2 Dec 2016 19:17:59 -0500 From: Yang Shi To: , CC: , , Subject: [PATCH] crypto: rsa - fix a potential race condition in build Date: Fri, 2 Dec 2016 15:41:04 -0800 Message-ID: <1480722064-31714-1-git-send-email-yang.shi@windriver.com> X-Mailer: git-send-email 2.0.2 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When building kernel with RSA enabled with multithreaded, the below compile failure might be caught: | /buildarea/kernel-source/crypto/rsa_helper.c:18:28: fatal error: rsapubkey-asn1.h: No such file or directory | #include "rsapubkey-asn1.h" | ^ | compilation terminated. | CC crypto/rsa-pkcs1pad.o | CC crypto/algboss.o | CC crypto/testmgr.o | make[3]: *** [/buildarea/kernel-source/scripts/Makefile.build:289: crypto/rsa_helper.o] Error 1 | make[3]: *** Waiting for unfinished jobs.... | make[2]: *** [/buildarea/kernel-source/Makefile:969: crypto] Error 2 | make[1]: *** [Makefile:150: sub-make] Error 2 | make: *** [Makefile:24: __sub-make] Error 2 The header file is not generated before rsa_helper is compiled, so adding dependency to avoid such issue. Signed-off-by: Yang Shi --- crypto/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/crypto/Makefile b/crypto/Makefile index 99cc64a..8db39f9 100644 --- a/crypto/Makefile +++ b/crypto/Makefile @@ -40,6 +40,7 @@ obj-$(CONFIG_CRYPTO_ECDH) += ecdh_generic.o $(obj)/rsapubkey-asn1.o: $(obj)/rsapubkey-asn1.c $(obj)/rsapubkey-asn1.h $(obj)/rsaprivkey-asn1.o: $(obj)/rsaprivkey-asn1.c $(obj)/rsaprivkey-asn1.h +$(obj)/rsa_helper.o: $(obj)/rsa_helper.c $(obj)/rsaprivkey-asn1.h clean-files += rsapubkey-asn1.c rsapubkey-asn1.h clean-files += rsaprivkey-asn1.c rsaprivkey-asn1.h -- 2.0.2