From: Pan Bian <bianpan2016@163.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
David Vrabel <david.vrabel@citrix.com>,
Juergen Gross <jgross@suse.com>,
xen-devel@lists.xenproject.org
Cc: linux-kernel@vger.kernel.org, Pan Bian <bianpan2016@163.com>
Subject: [PATCH 1/1] xen: xenbus: set error code on failure
Date: Sat, 3 Dec 2016 18:49:26 +0800 [thread overview]
Message-ID: <1480762166-4883-1-git-send-email-bianpan2016@163.com> (raw)
In function xenstored_local_init(), the value of return variable err
should be negative on errors. But the value of err keeps 0 even if the
call to get_zeroed_page() returns a NULL pointer. This patch assigns
"-ENOMEM" to err on the error branch.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188721
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/xen/xenbus/xenbus_probe.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
index 33a31cf..f87d047 100644
--- a/drivers/xen/xenbus/xenbus_probe.c
+++ b/drivers/xen/xenbus/xenbus_probe.c
@@ -708,8 +708,10 @@ static int __init xenstored_local_init(void)
/* Allocate Xenstore page */
page = get_zeroed_page(GFP_KERNEL);
- if (!page)
+ if (!page) {
+ err = -ENOMEM;
goto out_err;
+ }
xen_store_gfn = xen_start_info->store_mfn = virt_to_gfn((void *)page);
--
1.9.1
next reply other threads:[~2016-12-03 10:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 10:49 Pan Bian [this message]
2016-12-05 6:30 ` [PATCH 1/1] xen: xenbus: set error code on failure Juergen Gross
2016-12-05 7:50 ` Pan Bian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480762166-4883-1-git-send-email-bianpan2016@163.com \
--to=bianpan2016@163.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).