From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752287AbcLCMj4 (ORCPT ); Sat, 3 Dec 2016 07:39:56 -0500 Received: from m50-132.163.com ([123.125.50.132]:53963 "EHLO m50-132.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbcLCMjy (ORCPT ); Sat, 3 Dec 2016 07:39:54 -0500 From: Pan Bian To: Fabien Dessenne , Mauro Carvalho Chehab , linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Pan Bian Subject: [PATCH 1/1] media: platform: sti: return -ENOMEM on errors Date: Sat, 3 Dec 2016 20:39:33 +0800 Message-Id: <1480768773-5926-1-git-send-email-bianpan201602@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: DNGowACXGuwJvUJYCd0fIQ--.37706S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrZw43tr1xZr4rXr47tw1DKFg_yoWfZFX_Kw s7ZF4xWr10yr15Kw17t34Sva4Igr45WF1Fqa1SqFZxtw40kr9rXFyqvFZ7Xw15Xr1Sy347 Crn2vFyvkrZxGjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUY75r7UUUUU== X-Originating-IP: [222.131.246.88] X-CM-SenderInfo: held01tdqsiiqwqsqiywtou0bp/xtbBXg014FaDoxy8NQAAsl Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian Function bdisp_debugfs_create() returns 0 even on errors. So its caller cannot detect the errors. It may be better to return "-ENOMEM" on the exception paths. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188801 Signed-off-by: Pan Bian --- drivers/media/platform/sti/bdisp/bdisp-debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/sti/bdisp/bdisp-debug.c b/drivers/media/platform/sti/bdisp/bdisp-debug.c index 79c5635..7af6686 100644 --- a/drivers/media/platform/sti/bdisp/bdisp-debug.c +++ b/drivers/media/platform/sti/bdisp/bdisp-debug.c @@ -677,7 +677,7 @@ int bdisp_debugfs_create(struct bdisp_dev *bdisp) err: bdisp_debugfs_remove(bdisp); - return 0; + return -ENOMEM; } void bdisp_debugfs_remove(struct bdisp_dev *bdisp) -- 1.9.1