From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753870AbcLCOmu (ORCPT ); Sat, 3 Dec 2016 09:42:50 -0500 Received: from m50-135.163.com ([123.125.50.135]:49922 "EHLO m50-135.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753488AbcLCOlw (ORCPT ); Sat, 3 Dec 2016 09:41:52 -0500 From: Pan Bian To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Pan Bian Subject: [PATCH 1/1] staging: iio: cdc: fix improper return value Date: Sat, 3 Dec 2016 21:44:30 +0800 Message-Id: <1480772670-6898-1-git-send-email-bianpan201602@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: D9GowAB3rfI9zEJYm2iYIA--.39439S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtr4ruFy8uw4xCFWrtF4ktFb_yoW3uFX_Gw 4xZw4xJr1DZF17CwnxAF4fZ34IvFy7Ww4Fkr4Yqr9xKry3Can7A34qvF4DJ34DXry2kas0 9r4vyr17Kr17AjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUYkuctUUUUU== X-Originating-IP: [222.131.246.88] X-CM-SenderInfo: held01tdqsiiqwqsqiywtou0bp/1tbiKB814FWBVZNDnwAAss Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian At the end of function ad7150_write_event_config(), directly returns 0. As a result, the errors will be ignored by the callers. It may be better to return variable "ret". Signed-off-by: Pan Bian --- drivers/staging/iio/cdc/ad7150.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c index 5578a07..50a5b0c2 100644 --- a/drivers/staging/iio/cdc/ad7150.c +++ b/drivers/staging/iio/cdc/ad7150.c @@ -274,7 +274,7 @@ static int ad7150_write_event_config(struct iio_dev *indio_dev, error_ret: mutex_unlock(&chip->state_lock); - return 0; + return ret; } static int ad7150_read_event_value(struct iio_dev *indio_dev, -- 1.9.1