From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbcLCPOt (ORCPT ); Sat, 3 Dec 2016 10:14:49 -0500 Received: from m50-138.163.com ([123.125.50.138]:46191 "EHLO m50-138.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbcLCPOs (ORCPT ); Sat, 3 Dec 2016 10:14:48 -0500 From: Pan Bian To: Dave Airlie , David Airlie , Gustavo Padovan , Masahiro Yamada , Daniel Vetter , Sumit Semwal , Sean Paul , =?UTF-8?q?Christian=20K=C3=B6nig?= Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Pan Bian Subject: [PATCH 1/1] gpu: drm: qxl: fix use of uninitialized variable Date: Sat, 3 Dec 2016 23:11:42 +0800 Message-Id: <1480777902-7648-1-git-send-email-bianpan2016@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: C9GowAD3__Ov4EJYQx87IQ--.28625S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrZrW3Zr17Ar4fZw48Wr45ZFb_yoWDuFc_WF 48Gr4DZr18GF1DK3W7ArW3XFW2v3WDuFW8ZF9Iqa43try7Aw15Zr129rnxCw13ua97CFn0 9wsavrnxArn3WjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUeLjjDUUUUU== X-Originating-IP: [222.131.246.88] X-CM-SenderInfo: held01tdqsiiqw6rljoofrz/1tbiQBE1clSIRR-ugwAAs9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In function qxl_release_alloc(), when kmalloc() returns a NULL pointer, it returns value 0 and parameter *ret is uninitialized. 0 means no error to the callers of qxl_release_alloc(). The callers keep going and will try to reference the uninitialized variable. This patch fixes the bug, returning "-ENOMEM" when kmalloc() fails. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188911 Signed-off-by: Pan Bian --- drivers/gpu/drm/qxl/qxl_release.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_release.c b/drivers/gpu/drm/qxl/qxl_release.c index cd83f05..e6daa70 100644 --- a/drivers/gpu/drm/qxl/qxl_release.c +++ b/drivers/gpu/drm/qxl/qxl_release.c @@ -133,7 +133,7 @@ static long qxl_fence_wait(struct fence *fence, bool intr, signed long timeout) release = kmalloc(size, GFP_KERNEL); if (!release) { DRM_ERROR("Out of memory\n"); - return 0; + return -ENOMEM; } release->base.ops = NULL; release->type = type; -- 1.9.1