From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932937AbcLGTDi (ORCPT ); Wed, 7 Dec 2016 14:03:38 -0500 Received: from mga11.intel.com ([192.55.52.93]:64188 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753492AbcLGTDe (ORCPT ); Wed, 7 Dec 2016 14:03:34 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,315,1477983600"; d="scan'208";a="1078843654" Message-ID: <1481137266.15606.131.camel@intel.com> Subject: Re: [PATCH 0/4] UEFI: EFI_MEMORY_ATTRIBUTES_TABLE support for x86 From: Sai Praneeth Prakhya To: Matt Fleming Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, jlee@suse.com, bp@alien8.de, ricardo.neri@intel.com, ard.biesheuvel@linaro.org, ravi.v.shankar@intel.com, fenghua.yu@intel.com Date: Wed, 07 Dec 2016 11:01:06 -0800 In-Reply-To: <20161207135646.GC17720@codeblueprint.co.uk> References: <1481051763-8705-1-git-send-email-sai.praneeth.prakhya@intel.com> <20161207135646.GC17720@codeblueprint.co.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-12-07 at 13:56 +0000, Matt Fleming wrote: > On Tue, 06 Dec, at 11:15:59AM, Sai Praneeth Prakhya wrote: > > From: Sai Praneeth > > > > UEFI v2.6 introduces EFI_MEMORY_ATTRIBUTES_TABLE which describes memory > > protections that may be applied to EFI Runtime code and data regions by > > kernel. This helps kernel to map efi runtime regions more strictly and > > hence allowing only appropriate accesses to these regions. Please refer > > to "EFI_MEMORY_ATTRIBUTES_TABLE" in section 4.6 of UEFI specification > > v2.6 for more information on this table. > > > > This patch set relies on commit a604af075a32 ("efi: Add support for the > > EFI_MEMORY_ATTRIBUTES_TABLE config table"), commit 10f0d2f57705 ("efi: > > Implement generic support for the Memory Attributes table") and hence > > implements support for only x86. > > > > Since the above commits have already implemented early discovery and > > validation of table, the following patches implement a call back > > function for x86 which is called only when EFI_MEMORY_ATTRIBUTES_TABLE > > is detected. > > > > Patch #1 makes the efi_memory_attributes table detection code generic > > across all architectures > > > > Patch #2 adds EFI_MEM_ATTR bit to keep track of this feature > > > > Patch #3 Implements call back function that does stricter mappings based > > on this table > > > > Patch #4 Skip parsing of EFI_PROPERTIES_TABLE if EFI_MEMORY_ATTRIBUTES_TABLE > > is detected > > > > Sai Praneeth (4): > > efi: Make EFI_MEMORY_ATTRIBUTES_TABLE initialization common across all > > architectures > > efi: Introduce EFI_MEM_ATTR bit and set it from memory attributes > > table > > x86/efi: Add support for EFI_MEMORY_ATTRIBUTES_TABLE > > efi: Skip parsing of EFI_PROPERTIES_TABLE if > > EFI_MEMORY_ATTRIBUTES_TABLE is detected > > > > arch/x86/platform/efi/efi_64.c | 64 ++++++++++++++++++++++++++++++++++------- > > drivers/firmware/efi/arm-init.c | 1 - > > drivers/firmware/efi/efi.c | 13 +++++++++ > > drivers/firmware/efi/memattr.c | 6 +++- > > include/linux/efi.h | 1 + > > 5 files changed, 73 insertions(+), 12 deletions(-) > > Thanks Sai, I've queued this up for v4.11. Thanks Matt! Would you like to see a new version of these patch series addressing your comments? Like 1. Dropping of patch #4 2. Adding Reviewed-by tag of Joey (Sorry for that) 3. This time with correct version number Regards, Sai